Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implements shim for the GT5U ore vein database to serve VP's ore info #51

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

querns
Copy link

@querns querns commented Jul 29, 2024

With this PR, VisualProspecting will be able to fulfill queries about where veins are located for GT5U's new Ore Drilling Plant feature.

@querns
Copy link
Author

querns commented Jul 29, 2024

Oh, I also did a typo/grammar pass on the enUS lang file.

@Dream-Master Dream-Master requested a review from a team July 30, 2024 12:26
Copy link

@OneEyeMaker OneEyeMaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

And IMHO, English localized name is enough.

@Dream-Master Dream-Master merged commit be71d9f into GTNewHorizons:master Jul 30, 2024
1 check passed
@querns querns deleted the gt-vein-db-impl branch July 30, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants