More optimization & bug fixes #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning: 2 uncommitted changes |
Spotless apply for branch fixes for #55
|
Do a new review request when this is ready and I will look through it @Lyfts |
|
It's been ready |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most importantly this fixes only newly discovered veins being saved, it worked perfectly fine when migrating from the old cache but it would all be overwritten as soon as a new vein was discovered. (oops)
Some of the chunk analysis changes I made in #54 were missing far too many veins, it has been changed to something closer to what it was previously with some added checks for whether the primary meta matches & if ore can spawn in a given dimension (if it exists)
This is slightly slower but has a significantly lower miss rate, in a sample of ~11400 ore chunks only 178 were missed/couldn't be identified during the first pass and the vast majority of them were correctly identified in the second pass.
Okay I also got a larger sample size for shits and giggles:
43674 total ore veins of which
1968 had to be identified in second pass
351 failed to be identified (most are probably too high/low y level or just didn't spawn)
This means that 95.5% were correctly identified in the first pass and only 0.8% failed to be identified