-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RawOre to the OreProccessing Page #30
Conversation
confirmed compiled and working in game with the raw ores pr |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not too familiar with the raw ore changes, but I think I saw that the new raw ore macerator recipe is slightly different from the standard ore block macerator recipe? If that is true, and if players would normally be processing raw ore items rather than the standard ore blocks, then we may want to show the raw ore macerator outputs rather than the standard ore block macerator outputs.
If we wanted to do this, the line responsible for finding the macerator recipe is here:
Line 85 in bd52095
rawOre, |
and I think we would want to modify this block to prefer to select the raw ore item, if it exists:
Lines 66 to 72 in bd52095
if (!gregTechOres.isEmpty()) { | |
this.rawOre = gregTechOres.get(0); | |
} else if (!filteredRawOres.isEmpty()) { | |
this.rawOre = filteredRawOres.get(0); | |
} else { | |
this.rawOre = rawOres.get(0); | |
} |
Co-authored-by: GitHub GTNH Actions <>
Now it should be done @Dream-Master . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just wanted to check: all the lines line up okay when generating a diagram for an ore that doesn't have a raw ore item?
Also, I think the new layout is fine, but as a potential alternative to it, we could also keep the original layout, and just add the new raw ore item and different output chance to the existing slots. This would turn the slots into cycle slots, cycling between the ore block and raw ore much like how NEI usually shows crafting recipes that take multiple possible input items in a single spot.
If you want to try using cycle slots, and would like some code pointers, just let me know!
.../com/github/dcysteine/neicustomdiagram/generators/gregtech5/oreprocessing/LayoutHandler.java
Outdated
Show resolved
Hide resolved
...com/github/dcysteine/neicustomdiagram/generators/gregtech5/oreprocessing/DiagramBuilder.java
Show resolved
Hide resolved
...com/github/dcysteine/neicustomdiagram/generators/gregtech5/oreprocessing/DiagramBuilder.java
Outdated
Show resolved
Hide resolved
...com/github/dcysteine/neicustomdiagram/generators/gregtech5/oreprocessing/DiagramBuilder.java
Outdated
Show resolved
Hide resolved
.../com/github/dcysteine/neicustomdiagram/generators/gregtech5/oreprocessing/LayoutHandler.java
Outdated
Show resolved
Hide resolved
...hub/dcysteine/neicustomdiagram/generators/gregtech5/oreprocessing/GregTechOreProcessing.java
Outdated
Show resolved
Hide resolved
...hub/dcysteine/neicustomdiagram/generators/gregtech5/oreprocessing/GregTechOreProcessing.java
Outdated
Show resolved
Hide resolved
...com/github/dcysteine/neicustomdiagram/generators/gregtech5/oreprocessing/DiagramBuilder.java
Show resolved
Hide resolved
...hub/dcysteine/neicustomdiagram/generators/gregtech5/oreprocessing/GregTechOreProcessing.java
Outdated
Show resolved
Hide resolved
...hub/dcysteine/neicustomdiagram/generators/gregtech5/oreprocessing/GregTechOreProcessing.java
Outdated
Show resolved
Hide resolved
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great; thanks for adding this to the diagram!
This depends on #2502 and adds the Raw Ores to the ore processing page.
Changed the layout to show the raw ore item, and its chances