3Delight render sets and lightgroups support #5869
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generally describe what this PR will do, and why it is needed
Breaking changes
src/GafferScene/Render.cpp
andsrc/GafferScene/RenderController.cpp
to create NSI outputs after scene objects instead of global options. This is required for NSI since in order for the light objects and render sets to be successfully connected to the lightset output attribute they need to be created before declaring the lightset connection. Unlike the previous implementation this is now limited to 3Delight and doesn't affect the other renderers. @johnhaddon I know you mentioned in 3Delight extended outputs - outputlayers, lightsets, multilayer EXRs #5641 that declaring the outputs after the scene objects doesn't sound logical, but I checked the official Houdini NSI plugin and it exports the outputs after the scene as well (it even exports the global options after the outputs, but I don't think we need to do that on our end).Checklist