OSL Image Sampler Prototype Update #5963
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the old prototype of image sampling in OSL, hacked to get it working on top of Gaffer 1.4.
It's not in a good state at all now - in particular, I've just disabled vectorization here, since the previous version of this predates vectorization support for OSL in Gaffer. If anyone is seriously investigating this, we should at least get it working with vectorization, since that will have a dramatic impact on performance.
Anyways, despite the caveats, this is probably still in a better place to look at than looking at the previous build on Gaffer-1.0.3.0 ... the basic functionality does seem to be working.