Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AnimationEditor : Fix changing of frame by click & drag #6134

Open
wants to merge 1 commit into
base: 1.5_maintenance
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Changes.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ Fixes
- Render, InteractiveRender : Added default node name arguments to the compatibility shims for removed subclasses such as ArnoldRender.
- GafferUITest : Fixed `assertNodeUIsHaveExpectedLifetime()` test for invisible nodes.
- OpDialogue : Fixed `postExecuteBehaviour` handling.
- AnimationEditor : Fixed changing of the current frame by dragging the frame indicator or clicking on the time axis.

API
---
Expand Down
5 changes: 1 addition & 4 deletions python/GafferUI/AnimationEditor.py
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,7 @@ def __init__( self, scriptNode, **kw ) :

# Set up the widget responsible for actual curve drawing
self.__animationGadget = GafferUI.AnimationGadget()
self.__animationGadget.setContext( scriptNode.context() )

# Set up signals needed to update selection state in PathListingWidget
editable = self.__animationGadget.editablePlugs()
Expand Down Expand Up @@ -222,10 +223,6 @@ def _updateFromSet( self ) :
self.__pathChangedConnection = self.__curveList.getPath().pathChangedSignal().connect( Gaffer.WeakMethod( self.__updateGadgetSets ), scoped = True )
self.__updateGadgetSets()

def _updateFromContext( self, modifiedItems ) :

self.__animationGadget.setContext( self.context() )

def __updateGadgetSets( self, unused = None ) :

visiblePlugs = set()
Expand Down
Loading