Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settle pulse api url in the config.json #129

Merged
merged 2 commits into from
Aug 28, 2024

Conversation

DarumaDocker
Copy link
Contributor

Change two PUSH url to pulse endpoint, and replace them with node's subdomain in install.sh

Copy link
Contributor

juntao commented Aug 27, 2024

Hello, I am a code review agent on flows.network. Here are my reviews of changed source code files in this PR.


config.json

Potential issues

  1. Issue: The "address" field is empty, which might cause a connection failure when the code attempts to establish a network communication using this value.

  2. Issue: The URLs in the "chat", "embedding", and "snapshot" fields are not validated or checked for availability before use. This could lead to runtime errors if these resources become unavailable or if the URLs are incorrect.

  3. Issue: There is no error handling mechanism around the parsing of the "qdrant_limit" and "chat_batch_size" fields, which are expected to be integers but are currently represented as strings. This could lead to unexpected behavior or runtime errors if these values cannot be correctly parsed into an integer.

Summary of changes

  1. The "server_health_url" and "server_info_url" have been updated to new URLs that include a "$subdomain" variable, suggesting changes in the domain structure or server locations for these endpoints. This could indicate a shift towards dynamic subdomains based on user or node information.

  2. The old URLs used a placeholder hexadecimal string ("0x1234567890123456789012345678901234567890") that is no longer present in the new URLs, implying a move away from static identifiers towards more dynamic or variable server addresses.

  3. The domain has been changed from "httpbin.org" to "pulse.gaianet.ai", indicating a change of service provider for these endpoints, potentially signifying a partnership or integration with a new system.

install.sh

Potential issues

N/A

Summary of changes

  • Added a new command to replace the subdomain in the pulse API URL with the specified one.
  • Modified three configuration files (frpc.toml and config.json) by changing the existing subdomain value with the newly inputted one.
  • Updated the device ID file to store the device_id information.

@apepkuss
Copy link
Contributor

LGTM!

@apepkuss apepkuss merged commit 6d84da1 into GaiaNet-AI:main Aug 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants