Update wheel.yml to build ARM wheels and switch to trusted PyPi upload rather than using a token. #1298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
rmjarvis
added
build
|
Note also that I followed your lead in removing python 3.7 from our list of wheel builds. |
jmeyers314
approved these changes
Jun 7, 2024
| @@ -75,10 +106,16 @@ jobs: | |||
| # Just need to build sdist on a single machine | |||
There was a problem hiding this comment.
I think you'll need to update the above to
needs: [build_linux_wheels, build_musl_wheels, build_macosx_intel_wheels, build_macosx_arm_wheels]
.github/workflows/wheels.yml
Outdated
| build_macosx_wheels: | ||
| name: Build wheels on macosx | ||
| build_macosx_intel_wheels: | ||
| name: Build wheels on MacOS Intel | ||
| runs-on: macos-latest |
There was a problem hiding this comment.
You might need to change this to macos-13 to get an intel runner. It's possible an ARM runner will cross-compile though, just need to try and see I guess.
|
Thanks! I think you're right on both counts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for releasing version 2.5.3, I added arm wheels to our wheels.yaml script.
Also, PyPi now prefers using trusted publishing. (cf. https://docs.pypi.org/trusted-publishers/adding-a-publisher/) So I switched to that as well.
This is hard to confirm before actually running the script, which will happen when we make the release tag v2.5.3. But @jmeyers314 if you can look through it once to see if there are any errors that you can notice in advance, that would be appreciated.