Fix Python 3 compatibility, remove some unused modules #1308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
732 passed, 1 skipped in 225.68s (0:03:45)
|
These are different results when Im running it locally. Maybe I should back out of trying to commit to GalSim; Im not advanced enough to fix this. Sorry for the confusion. |
|
These changes are all in the devel directory. That is (as the name implies) a sandbox area for developers. Not code that needs to be maintained. The files you are updating are at best of historical interest at this point to document how various things were developed a long time ago. I'm inclined to reject this PR as unnecessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests:
732 passed, 1 skipped in 225.68s (0:03:45)Test_photon_array.py ......s...........