Use builtin methods on lists #1316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmjarvis
approved these changes
Oct 24, 2024
There were a number of places where library was misspelt. This commit fixes those typos.
arunkannawadi
force-pushed
the
u/arunkannawadi/builtins-on-lists
branch
from
8a48933
to
82feef0
Compare
|
Oh, I don't doubt that one bit. These are some changes that I had to do anyway to get my hacky version running. Btw, I'm not in any hurry and this need not result in a patch release immediately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have been spending some time this week hacking GalSim and noticed a few places where builtins are known to be faster than the
numpyequivalents generally. This is not likely to move the needle in terms of the overall efficiency, but this is something I had to do anyway during the hack and I thought I might as well try to get it merged here.