Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenCL Language Server Refactoring #20

Merged
merged 32 commits into from
Aug 25, 2023
Merged

OpenCL Language Server Refactoring #20

merged 32 commits into from
Aug 25, 2023

Conversation

Galarius
Copy link
Owner

@Galarius Galarius commented Aug 23, 2023 •
edited
Loading

  • Improve URI to file path conversion
  • Accept --stdout flag
  • Add diagnostics command
  • Replace --clinfo flag with clinfo command
  • Improve performance
  • Add tests

@Galarius
Refactor jsonrpc
2969e70
@Galarius
Fix clang-format toggle
dbaa694
@Galarius
Update gitignore
f188d12
@Galarius
Define IJsonRPC interface and hide JsonRPC class impl
31b865b
@Galarius
Make diagnostics and jrpc instances injectable into lsp
b9074bd
@Galarius
Move json-rpc tests to a separate file
a2c35e7
@Galarius
Refactor LSPServer for better testability
aab26e8
@Galarius
Refactor LSPServerEventsHandler::OnInitialize and add tests
c1af853
@Galarius
Refactor OnInitialized, optimize id generation, add tests
d11aa7d
@Galarius
Add test for LSPServerEventsHandler::BuildDiagnosticsRespond
c3c3c2c
@Galarius
Add test for throwing LSPServerEventsHandler::BuildDiagnosticsRespond
03b4126
@Galarius
Add test for LSPServerEventsHandler::OnTextOpen and OnTextChanged
aeffd69
@Galarius
Update LSPServerEventsHandler::OnConfiguration and add test
d2a79a7
@Galarius
Add test for LSPServerEventsHandler::GetConfiguration and OnRespond
a77cb95
@Galarius
Format lsp code
2b9778b
@Galarius
Add test for LSPServerEventsHandler::OnShutdown and OnExit
c58aac4
@Galarius
Replace --clinfo with subcommand
8b23afe
@Galarius
Add 'diagnostics' subcommand
8c79452
@Galarius
[#19] Add uriparser dependency to convert URI to file path
9679a06
@Galarius
Update test_package to support 'clinfo' subcommand
9436274
@Galarius
Refactor Diagnostics class
c5d3e26
@Galarius
Create DiagnosticsParser class & tests
68ad122
@Galarius
Add 'diagnostics' tests
a102020
@Galarius
Refactor utils, add tests
2fd144d
@Galarius
Refactor logging
4f23ba3
@Galarius
Refactor log messages
5e914cc
@Galarius
Apply multiple fixes
956e04c 
* Fix `diagnostics` to be empty instead of `null`
* Remove duplicate `BuildSource` call
* Remove `id` validation in `OnInitialized` handler
* Add `--stdio` flag, since VS Code extension adds it
* Update tests
@Galarius Galarius force-pushed the feature/refactoring branch 2 times, most recently from e543c0e to 45e709d Compare August 23, 2023 19:43
@Galarius Galarius force-pushed the feature/refactoring branch 3 times, most recently from cc41384 to a17c83a Compare August 25, 2023 16:44
@Galarius Galarius marked this pull request as ready for review August 25, 2023 17:15
@Galarius Galarius merged commit af4f482 into main Aug 25, 2023
3 checks passed
@Galarius Galarius deleted the feature/refactoring branch August 26, 2023 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Galarius