Change the tf/task jwt token management #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Writes jwt tokens to a secret and sourced into a task. JWTs now come with single use refresh token. A new login endpoint is used to refresh tokens @ `/refresh`
From personal experience, its more common for k8s networking to fail than database entries to fail. For this reason, the k8s secret updater is moved before modifying the database. Either way, this change is not the best solution to handle failure sceanrios, but it's "good enough".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Writes jwt tokens to a secret and sourced into a task. JWTs now come with single use refresh token. A new login endpoint is used to refresh tokens @
/refresh