Allow building with GHC 9.6 #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a simple matter of bumping version bounds.
kquick
approved these changes
Aug 3, 2023
RyanGlScott
added a commit
to GaloisInc/cryptol
that referenced
this pull request
Aug 31, 2023
This contains a varity of changes needed to make `cryptol` compile with GHC 9.6: * `mtl-2.3.1` (bundled with GHC 9.6) no longer re-exports `Control.Monad` or related modules from the various `mtl` modules. I now use explicit imports from `mtl` modules to ensure that the necessary identifiers are always in scope, regardless of whether we are using `mtl-2.3.*` or an older `mtl` version. * `directory-1.3.8.0` (bundled with GHC 9.6) no longer marks its modules as `Safe`, so `Cryptol.TypeCheck.Solver.SMT` (a module explicitly marked as `Safe`) no longer compiles due to its `System.Directory` import. I have changed `Cryptol.TypeCheck.Solver.SMT` to be `Trustworthy` instead to avoid this. * I have raised the upper version bounds on libraries such as `base` and `aeson` to allow a GHC 9.6–compatible build plan. * I have bumped the `argo` submodule to bring in the changes from GaloisInc/argo#200, which allows `argo` to build with GHC 9.6.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a simple matter of bumping version bounds.
Along the way, I also fixed a warning uncovered with recent GHCs and updated the CI.