Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using blocking network IO to avoid busy-wait #216

Merged
merged 5 commits into from
Sep 4, 2024
Merged

Using blocking network IO to avoid busy-wait #216

merged 5 commits into from
Sep 4, 2024

Conversation

glguy
Copy link
Member

@glguy glguy commented Sep 4, 2024

This change also makes the netstring parser more robust to support the way that it's used in the network loop

@glguy glguy force-pushed the glguy/blocking-io branch 2 times, most recently from 7d2ce57 to dd4ed90 Compare September 4, 2024 00:39
@glguy
Using blocking network IO to avoid busy-wait
4a778f8 
This change also makes the netstring parser more robust to support the way that it's used in the network loop
RyanGlScott
RyanGlScott reviewed Sep 4, 2024
View reviewed changes
Copy link
Contributor

@RyanGlScott RyanGlScott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you verified that the test suite for the Cryptol Python bindings continues to pass after these changes? (I recall that getting the network code just right for the test suite was very tricky, so it would be good to check to be on the safe side.)

python/argo_client/netstring.py Show resolved Hide resolved
python/argo_client/netstring.py Outdated Show resolved Hide resolved
python/argo_client/connection.py Show resolved Hide resolved
@glguy
Copy link
Member Author

glguy commented Sep 4, 2024

Have you verified that the test suite for the Cryptol Python bindings continues to pass after these changes? (I recall that getting the network code just right for the test suite was very tricky, so it would be good to check to be on the safe side.)

./run_rpc_tests.sh passes

@glguy glguy merged commit c34f0aa into master Sep 4, 2024
6 checks passed
@glguy glguy deleted the glguy/blocking-io branch September 4, 2024 20:51
RyanGlScott added a commit to GaloisInc/cryptol that referenced this pull request Sep 18, 2024
@RyanGlScott
Python: Require argo-client >=0.0.13
3e70df9 
This updates the `cryptol` Python bindings to require the use of
`argo-client-0.0.13` or later, bringing in the performance improvements from
GaloisInc/argo#216.
@RyanGlScott RyanGlScott mentioned this pull request Sep 18, 2024
Merged
RyanGlScott added a commit to GaloisInc/saw-script that referenced this pull request Sep 18, 2024
@RyanGlScott
Python: Require argo-client >= 0.0.13 and cryptol 3.2.1
c32af16 
This updates the `saw-client` Python bindings to require the use of
`argo-client-0.0.13` or later, bringing in the performance improvements from
GaloisInc/argo#216. It also brings in the use of `cryptol-3.2.1`, which is
compatible with `argo-client-0.0.13` or later.
@RyanGlScott RyanGlScott mentioned this pull request Sep 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RyanGlScott RyanGlScott RyanGlScott approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@glguy @RyanGlScott