Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweaks to line breaking in pretty printer. #1292

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Tweaks to line breaking in pretty printer. #1292

wants to merge 1 commit into from

Conversation

brianhuffman
Copy link
Contributor

Fixes #1289.

@brianhuffman
Copy link
Contributor Author

I should probably add a couple of tests to demonstrate the changed line breaking behavior before merging.

robdockins
robdockins approved these changes Sep 27, 2021
View reviewed changes
Copy link
Contributor

@robdockins robdockins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable at a glance, although it's pretty hard to work out the effects just from looking at the patch.

@RyanGlScott RyanGlScott added this to the 2.14.0 milestone May 10, 2022
@RyanGlScott RyanGlScott modified the milestones: 2.14.0, 2.15.0 Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robdockins robdockins robdockins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.2.0
Development

Successfully merging this pull request may close these issues.

Prettyprinter puts linebreaks in awkard places within type expressions
3 participants
@brianhuffman @robdockins @RyanGlScott