Fix splitV when splitting empty sequence to type [inf][0]
#1750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RyanGlScott
temporarily deployed
to
github-pages
GitHub Actions
Inactive
I found the code in `splitV` hard to read, so this commit performs some mild refactoring to improve things somewhat: 1. There are multiple cases where `parts` can be either `Nat` or `Inf`, but the two `Nat` cases were far away from each other visually (and similarly for the two `Inf` cases). 2. The code was pattern-matching on `each` for no good reason, as every case treated `each` as a bare variable. I've removed this match. There is no change in behavior, just refactoring.
Previously, `splitV` would assume that if you were splitting a value `val` into something of type `[inf][each]`, then `val` must be a stream of type of `[inf * each]` (i.e., of type `[inf]`). This is not true in the corner case where `each` equals `0`, however. In that case, `val` is of type `[0]`, which is a word, not a stream. As such, we need to ensure that we do not call `fromSeq` on `val`, which crashes if `val` is not a stream or sequence. Fixes #1749.
RyanGlScott
temporarily deployed
to
github-pages
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
splitVwould assume that if you were splitting a valuevalinto something of type[inf][each], thenvalmust be a stream of type of[inf * each](i.e., of type[inf]). This is not true in the corner case whereeachequals0, however. In that case,valis of type[0], which is a word, not a stream. As such, we need to ensure that we do not callfromSeqonval, which crashes ifvalis not a stream or sequence.Fixes #1749.