Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add shutdown method to nodejs api #7

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

feat: add shutdown method to nodejs api #7

wants to merge 6 commits into from

Conversation

vindard
Copy link
Contributor

@vindard vindard commented Apr 3, 2024

Description

This 1st iteration listens for the shutdown signal alongside the awaitOutboxServer call via a oneshot channel. Iterations could be to:

  • use mpsc instead of oneshot to allow multiple shutdown signals if shutdown is called and consumed before awaitOutboxServer executes
  • move select to CalaLedger init method somehow if we decide we'd like to abort the server Future before it's awaited

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@vindard