Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Adding html files for error-messages #63

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

bmaxtar
Copy link
Contributor

@bmaxtar bmaxtar commented Nov 5, 2024

No description provided.

Copy link
Member

@NDOY3M4N NDOY3M4N left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je pense qu'il serait plus juducieux d'appeler ce component Alert message. Et on pourrait avoir plusieurs variations du même components comme le fait Bootstrap

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Il y a un bug au niveau du chargement. Je suggère de renommer ce fichier => galsen-ui-error-messages.mdx (au pluriel) car tu as placé tes composants HTML au niveau du dossier public/components/error-messages. La nommenclature doit rester la même.

@bmaxtar
Copy link
Contributor Author

bmaxtar commented Nov 5, 2024

Hum je vois l'idée, je ferai la modif inshalla 👍🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants