Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 🧱 add design system #346

Merged
merged 1 commit into from
Oct 30, 2023
Merged

feat: 🧱 add design system #346

merged 1 commit into from
Oct 30, 2023

Conversation

JohnsonMao
Copy link
Contributor

Why need this change? / Root cause:

  • New design system released.

Changes made:

  • add tailwindCSS config
  • modify body backgound

Test Scope / Change impact:

Issue

Note

  • 顏色定義為與 figma 相同的 primary, secondary, error, gray and basic
  • 添加 fz-{數字} 來定義字型大小與行高以符合設計稿並方便使用
  • 添加 gradient-purple, gradient-black 背景漸層色
  • 添加 border-gradient-purple 為 border 漸層色

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@GaaSBot
Copy link

GaaSBot commented Oct 24, 2023

Knip Scan Result for 4af91c0

Unused files (10)
Unused files (10)
.bundlewatch.config.js
components/shared/Chat/ChatContent.tsx
components/shared/Chat/ChatMessage.tsx
components/shared/Chat/index.tsx
components/shared/Icon/group/news.tsx
configs/i18nConfigs.ts
lighthouserc.js
reset.d.ts
scripts/knipScanReporter.js
scripts/lhciScanReporter.js
Unused dependencies (2)
Unused dependencies (2)
@svgr/webpack package.json
sharp package.json
Unused devDependencies (5)
Unused devDependencies (5)
@actions/github package.json
@octokit/core package.json
@storybook/blocks package.json
@storybook/testing-library package.json
@total-typescript/ts-reset package.json
Configuration issues (1)
Configuration issues (1)
Unused item in ignoreDependencies: @next/bundle-analyzer

@GaaSBot
Copy link

GaaSBot commented Oct 24, 2023

🤖 Lighthouse Scan Result for 4af91c0

/rooms
Metric Value
Performance 67
Seo 80
Accessibility 79
HTML Report for LHCI Scan Report Link
/rooms/abc
Metric Value
Performance 76
Seo 80
Accessibility 66
HTML Report for LHCI Scan Report Link
/login
Metric Value
Performance 47
Seo 80
Accessibility 94
HTML Report for LHCI Scan Report Link

@JohnsonMao JohnsonMao changed the title 🧱 add design system feat: 🧱 add design system Oct 25, 2023
@github-actions github-actions bot added the feature New Feature label Oct 25, 2023
Copy link
Contributor

@Yuwen-ctw Yuwen-ctw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JohnsonMao JohnsonMao merged commit 9b8c42b into main Oct 30, 2023
8 of 9 checks passed
@JohnsonMao JohnsonMao deleted the infra/design-system branch October 30, 2023 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants