-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a Menu Bar to Tesseratos #1235
base: main
Are you sure you want to change the base?
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1235 +/- ##
=======================================
Coverage 36.27% 36.27%
=======================================
Files 376 376
Lines 30851 30851
=======================================
+ Hits 11191 11192 +1
+ Misses 19660 19659 -1 ☔ View full report in Codecov by Sentry. |
9756791
to
13a4bd3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clang-Tidy
found issue(s) with the introduced code (1/1)
13a4bd3
to
bcea446
Compare
Description
Adds a menu bar plugin to Tesseratos. This plugin basically picks up all entities with the
MenuBarItem
component, and shows them in the menu bar.Additionally, ChildOf hierarchies lead to having drop-down menus within the bar.
Check out the editor
main.cpp
for an example of how these entities can be created.Down the road, we should change plugins to add their own entries there.
User interaction is handled through observers: if the user selects an item in the menu, the
MenuBarSelected
component is added and immediately removed. This triggers any.onAdd<MenuBarSelected>
observers added by users.Checklist
Ensure test coverage.Write new samples.