Port to web #1263
Draft
Port to web #1263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
github-actions
bot
added
A-Core
A-Engine
B-Build
|
luishfonseca
force-pushed
the
465-port-to-web
branch
2 times, most recently
from
1652c4f
to
1354f0b
Compare
Note that this turned out not to be enough to support webgl 2.0 See https://registry.khronos.org/webgl/specs/latest/2.0/#5.14
RiscadoA
force-pushed
the
465-port-to-web
branch
2 times, most recently
from
b6f5b1c
to
c7c0259
Compare
luishfonseca
force-pushed
the
465-port-to-web
branch
from
c7c0259
to
31108c1
Compare
luishfonseca
force-pushed
the
465-port-to-web
branch
from
31108c1
to
832c19b
Compare
RiscadoA
force-pushed
the
465-port-to-web
branch
from
832c19b
to
1097fcb
Compare
luishfonseca
force-pushed
the
465-port-to-web
branch
from
1097fcb
to
832c19b
Compare
RGB isn't supported in WebGL 2 and Opengl ES 3.
RiscadoA
force-pushed
the
465-port-to-web
branch
from
832c19b
to
15a4797
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| return id; | ||
| // The pixel pack buffer holds data in the RGBA32UInt format. | ||
| glm::uvec4 pixel; | ||
| this->pixelBuffer->copyTo(&pixel, (y * this->size.x + x) * 16U, 16U); |
There was a problem hiding this comment.
performing an implicit widening conversion to type std::size_t (aka unsigned long) of a multiplication performed in type unsigned int
luishfonseca
force-pushed
the
465-port-to-web
branch
from
15a4797
to
7ead7d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For now, nukes a bunch of WebGL incompatible code
Checklist