-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
-O3 flag causes compiler error on ECS QueryFilter #1352
Open
SrGesus
wants to merge
2
commits into
main
Choose a base branch
from
1351-o3-flag-causes-compiler-error-on-ecs-queryfilter
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
-O3 flag causes compiler error on ECS QueryFilter #1352
SrGesus
wants to merge
2
commits into
main
from
1351-o3-flag-causes-compiler-error-on-ecs-queryfilter
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SrGesus
requested review from
jdbaracho and
RodrigoVintem
and removed request for
a team
October 22, 2024 09:22
github-actions
bot
added
A-Core
B-ECS
C-Compile-Error
D-Trivial
Can be done in 30 minutes
labels
Oct 22, 2024
|
SrGesus
requested review from
a team and
jdbaracho
and removed request for
jdbaracho and
a team
October 22, 2024 09:27
RiscadoA
approved these changes
Oct 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ty very much for chasing these bugs 🙏 LGTM other than the comment
SrGesus
requested review from
RiscadoA
and removed request for
RodrigoVintem and
jdbaracho
October 22, 2024 09:36
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1352 +/- ##
=======================================
Coverage 41.54% 41.54%
=======================================
Files 437 437
Lines 32850 32852 +2
Branches 3820 3820
=======================================
+ Hits 13646 13647 +1
- Misses 19204 19205 +1 ☔ View full report in Codecov by Sentry. |
SrGesus
force-pushed
the
1351-o3-flag-causes-compiler-error-on-ecs-queryfilter
branch
from
October 22, 2024 09:52
a297cef
to
448078a
Compare
RiscadoA
approved these changes
Oct 22, 2024
joaomanita
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added an assert that mNodeCount is smaller than the array size.
Had to also add some kind of "aliasing" to mNodeCount because the compiler thinks it might be mutated.
Context
Checklist