Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add warm starting #1389

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Add warm starting #1389

wants to merge 1 commit into from

Conversation

fallenatlas
Copy link
Contributor

Description

Putting this here just bc I'm going to nuke the entire repository.

Checklist

  • Self-review changes.
  • Evaluate impact on the documentation.
  • Ensure test coverage.
  • Write new samples.
  • Add entry to the changelog's unreleased section.

@fallenatlas fallenatlas added this to the 0.6 milestone Nov 25, 2024
@fallenatlas fallenatlas self-assigned this Nov 25, 2024
@fallenatlas fallenatlas linked an issue Nov 25, 2024 that may be closed by this pull request
Implement Warm starting #1248
Open
@github-actions GitHub Actions
Copy link
Contributor

PR Preview Action v1.4.8
🚀 Deployed preview to https://GameDevTecnico.github.io/cubos/preview/pr-1389/
on branch gh-pages at 2024-11-25 10:36 UTC

github-actions[bot]
github-actions bot reviewed Nov 25, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (1/1)

engine/src/physics/solver/penetration_constraint/plugin.cpp
pointData.normalImpulse = 0.0F;
pointData.frictionImpulse1 = 0.0F;
pointData.frictionImpulse2 = 0.0F;
pointData.normalImpulse = point.normalImpulse;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-diagnostic-error ⚠️
no member named normalImpulse in cubos::engine::ContactPointData

engine/src/physics/solver/penetration_constraint/plugin.cpp
pointData.frictionImpulse1 = 0.0F;
pointData.frictionImpulse2 = 0.0F;
pointData.normalImpulse = point.normalImpulse;
pointData.frictionImpulse1 = point.frictionImpulse1;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-diagnostic-error ⚠️
no member named frictionImpulse1 in cubos::engine::ContactPointData

engine/src/physics/solver/penetration_constraint/plugin.cpp
pointData.frictionImpulse2 = 0.0F;
pointData.normalImpulse = point.normalImpulse;
pointData.frictionImpulse1 = point.frictionImpulse1;
pointData.frictionImpulse2 = point.frictionImpulse2;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-diagnostic-error ⚠️
no member named frictionImpulse2 in cubos::engine::ContactPointData

engine/src/physics/solver/penetration_constraint/plugin.cpp
{
auto [entity, manifold, other] = *match;
// CUBOS_DEBUG("msize: {}, csize: {}", manifold.points.size(), constraint.points.size());
for (int i = 0; i < manifold.points.size(); i++)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-diagnostic-sign-compare ⚠️
comparison of integers of different signs: int and std::vector::size_type (aka unsigned long)

engine/src/physics/solver/penetration_constraint/plugin.cpp
// CUBOS_DEBUG("msize: {}, csize: {}", manifold.points.size(), constraint.points.size());
for (int i = 0; i < manifold.points.size(); i++)
{
manifold.points[i].normalImpulse = constraint.points[i].normalImpulse;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-diagnostic-error ⚠️
no member named normalImpulse in cubos::engine::ContactPointData

engine/src/physics/solver/penetration_constraint/plugin.cpp
for (int i = 0; i < manifold.points.size(); i++)
{
manifold.points[i].normalImpulse = constraint.points[i].normalImpulse;
manifold.points[i].frictionImpulse1 = constraint.points[i].frictionImpulse1;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-diagnostic-error ⚠️
no member named frictionImpulse1 in cubos::engine::ContactPointData

engine/src/physics/solver/penetration_constraint/plugin.cpp
{
manifold.points[i].normalImpulse = constraint.points[i].normalImpulse;
manifold.points[i].frictionImpulse1 = constraint.points[i].frictionImpulse1;
manifold.points[i].frictionImpulse2 = constraint.points[i].frictionImpulse2;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-diagnostic-error ⚠️
no member named frictionImpulse2 in cubos::engine::ContactPointData

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@RiscadoA RiscadoA Awaiting requested review from RiscadoA RiscadoA will be requested when the pull request is marked ready for review RiscadoA is a code owner

At least 3 approving reviews are required to merge this pull request.

Assignees

@fallenatlas fallenatlas

Labels
A-Engine B-Physics
Projects
None yet
Milestone
0.6
Development

Successfully merging this pull request may close these issues.

Implement Warm starting
1 participant
@fallenatlas