Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gizmos): fix gizmos selection on HiDPI screens #1405

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

diogomsmiranda
Copy link
Contributor

@diogomsmiranda diogomsmiranda commented Dec 9, 2024

Description

This fixes the selection of gizmos on HiDPI screens.

Checklist

  • Self-review changes.
  • Evaluate impact on the documentation.
  • Ensure test coverage.
  • Write new samples.
  • Add entry to the changelog's unreleased section.

@diogomsmiranda diogomsmiranda self-assigned this Dec 9, 2024
@diogomsmiranda diogomsmiranda requested review from RiscadoA and a team as code owners December 9, 2024 13:19
@diogomsmiranda diogomsmiranda requested review from jdbaracho and removed request for a team December 9, 2024 13:19
@diogomsmiranda diogomsmiranda linked an issue Dec 9, 2024 that may be closed by this pull request
@diogomsmiranda diogomsmiranda requested review from SrGesus and removed request for a team December 9, 2024 13:19
@github-actions github-actions bot added the O-MacOS Related to macOS builds label Dec 9, 2024
@RiscadoA RiscadoA changed the title fix(gizmos): fix gizmos selection on apple silicone fix(gizmos): fix gizmos selection on HiDPI screens Dec 9, 2024
@RiscadoA RiscadoA removed the O-MacOS Related to macOS builds label Dec 9, 2024
Copy link
Contributor

github-actions bot commented Dec 9, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://GameDevTecnico.github.io/cubos/preview/pr-1405/
on branch gh-pages at 2024-12-09 13:21 UTC

Copy link
Member

@RiscadoA RiscadoA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but change the commit message to fix(rendering): consider HiDPI screens when using the render picker, and add a similar entry to the changelog unreleased section

@RiscadoA RiscadoA added this to the 0.6 milestone Dec 9, 2024
@diogomsmiranda diogomsmiranda force-pushed the 1283-gizmos-wont-appear-in-mac-os branch 3 times, most recently from 8f91d02 to 683fcc3 Compare December 9, 2024 13:34
@diogomsmiranda diogomsmiranda force-pushed the 1283-gizmos-wont-appear-in-mac-os branch from 683fcc3 to 05c4ba2 Compare December 9, 2024 13:35
Copy link

codecov bot commented Dec 9, 2024

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 53.42%. Comparing base (9d530fe) to head (05c4ba2).

Files with missing lines Patch % Lines
engine/src/gizmos/plugin.cpp 0.00% 5 Missing ⚠️
engine/src/tools/selection/plugin.cpp 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1405      +/-   ##
==========================================
- Coverage   53.43%   53.42%   -0.02%     
==========================================
  Files         462      462              
  Lines       25850    25856       +6     
  Branches     2389     2389              
==========================================
  Hits        13813    13813              
- Misses      12037    12043       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@SrGesus SrGesus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants