Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SSAO resolution scale #1424

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

tomas7770
Copy link
Contributor

@tomas7770 tomas7770 commented Dec 22, 2024

Description

Adds a resolution scale value to the SSAO component to adjust the SSAO texture size. The default value of 0.5 provides a good quality with much better performance than full resolution (1.0).

Checklist

  • Self-review changes.
  • Evaluate impact on the documentation.
  • Ensure test coverage.
  • Write new samples.
  • Add entry to the changelog's unreleased section.

@tomas7770 tomas7770 added this to the 0.6 milestone Dec 22, 2024
@tomas7770 tomas7770 self-assigned this Dec 22, 2024
@tomas7770 tomas7770 linked an issue Dec 22, 2024 that may be closed by this pull request
@github-actions github-actions bot added A-Engine B-Rendering C-Optimization P-Urgent This issue is a big priority, and it would be good to close it ASAP labels Dec 22, 2024
Copy link
Contributor

PR Preview Action v1.4.8
🚀 Deployed preview to https://GameDevTecnico.github.io/cubos/preview/pr-1424/
on branch gh-pages at 2024-12-22 13:15 UTC

Copy link

codecov bot commented Dec 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 16 lines in your changes missing coverage. Please review.

Project coverage is 53.40%. Comparing base (395ff0d) to head (4b4da14).

Files with missing lines Patch % Lines
engine/src/render/ssao/plugin.cpp 0.00% 15 Missing ⚠️
engine/src/render/ssao/ssao.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1424      +/-   ##
==========================================
- Coverage   53.42%   53.40%   -0.03%     
==========================================
  Files         462      462              
  Lines       25854    25865      +11     
  Branches     2391     2392       +1     
==========================================
  Hits        13813    13813              
- Misses      12041    12052      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tomas7770 tomas7770 marked this pull request as ready for review December 22, 2024 13:46
@tomas7770 tomas7770 requested review from RiscadoA and a team as code owners December 22, 2024 13:46
@tomas7770 tomas7770 requested review from GalaxyCrush, kuukitenshi and Dageus and removed request for a team and Dageus December 22, 2024 13:46
Copy link

cubos-bot bot commented Dec 24, 2024

@RiscadoA will only be able to review this PR in 3 days.

Copy link

cubos-bot bot commented Dec 24, 2024

@GalaxyCrush will only be able to review this PR in 3 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Engine B-Rendering C-Optimization P-Urgent This issue is a big priority, and it would be good to close it ASAP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add SSAO resolution scale
1 participant