Metallurgy 1.21: Lore Line Shrink #1078
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
misode
added
feature-update
misode
reviewed
Dec 8, 2024
| @@ -2,12 +2,30 @@ | |||
| # run from smooshing/remove_band/check | |||
|
|
|||
| execute if score custom_model_data gm4_ml_data matches 0 run data remove entity @s Item.components."minecraft:custom_model_data" | |||
| execute if items entity @s contents *[custom_data~{gm4_metallurgy:{active_shamir:"infinitas"}}] run data remove entity @s Item.components."minecraft:max_stack_size" | |||
There was a problem hiding this comment.
Why does infinitas need special handling? Maybe include a comment about this in the function
|
This is now waiting on some 1.21.5 changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, Metallurgy shamir lore takes up 3 lines
Name: Obsidian Cast
Lore: Band
Shamir
This update removes that standalone "Shamir" line to only use 2 lines
Name: Obsidian Cast
Lore: Band
Shamir
This change is part of the larger Metallurgy redesign.
Existing items will not have " Shamir" appended to the end, but will function the same. This also means old unattached bands will not be stackable with shamirs created after this update.