Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: PromiseLike bug: sync with Turbowarp #3

Closed
wants to merge 1 commit into from
Closed

fix: PromiseLike bug: sync with Turbowarp #3

wants to merge 1 commit into from

Conversation

FurryR
Copy link
Contributor

@FurryR FurryR commented Jan 27, 2024

Related pull request (merged): TurboWarp/scratch-vm#185

Resolves

TurboWarp/scratch-vm#184

Proposed Changes

  • Fix PromiseLike support in waitPromise() function
  • Fix unintended promise.catch usage in waitPromise() function

Reason for Changes

From TurboWarp/scratch-vm#184:

  • Compiler's waitPromise soft-lock if promise handlers executed immediately.

Test Coverage

Test unit from TurboWarp

@FurryR FurryR closed this by deleting the head repository Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant