Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update prettier entrypoint.sh to consider dry run #8

Merged
merged 2 commits into from
Apr 24, 2024
Merged

Update prettier entrypoint.sh to consider dry run #8

merged 2 commits into from
Apr 24, 2024

Commits on Apr 24, 2024

  1. Update entrypoint.sh to consider dry run 

    When dry-run is set to true and we use the --write flag, we expect to
see what files we'll need to reformat without pushing to remote.
However, this requires us to commit the updated changes caused by
prettier. Previously, the placement of the dry run logic was done before
committing the formatted files, resulting to us not seeing the expected
files format. And only using the '--write' flag will not result to a
failure even if there are files that requires formatting.

By moving the logic after committing the prettier files, it will show us
the comparison between two files, without pushing to remote
(given that we use dry flag to true).
    @Anu48
    Anu48 committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    38602fe View commit details
    Browse the repository at this point in the history

  2. Update description for dry mode

    @Anu48
    Anu48 committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    83c532e View commit details
    Browse the repository at this point in the history