-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Install pyarrow-core instead of pyarrow from conda-forge #3698
Conversation
Reduce unnecessary optional dependencies when installing `pyarrow` from conda-forge. Xref conda-forge/pyarrow-feedstock#111
@@ -73,7 +73,7 @@ jobs: | |||
numpy-version: '1.25' | |||
pandas-version: '=2.0' | |||
xarray-version: '=2023.04' | |||
optional-packages: ' contextily geopandas<1 ipython pyarrow rioxarray sphinx-gallery' | |||
optional-packages: ' contextily geopandas<1 ipython pyarrow-core rioxarray sphinx-gallery' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also need to update line 82.
Do we also want to update doc/install.md
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aslo need to note that pyarrow-core is available since pyarrow v16 (released in April, 2024). Installing |
|
Description of proposed changes
Reduce unnecessary optional dependencies when installing
pyarrow
from conda-forge. Xref conda-forge/pyarrow-feedstock#111From https://github.com/conda-forge/pyarrow-feedstock/blob/381a88b6f8957204e34047151c4ca8a3f1e54204/recipe/meta.yaml#L157-L164, this means we won't be installing
libarrow-acero
,libarrow-dataset
,libarrow-substrait
andlibparquet
.Fixes #
Preview:
Reminders
make format
andmake check
to make sure the code follows the style guide.doc/api/index.rst
.Slash Commands
You can write slash commands (
/command
) in the first line of a comment to performspecific operations. Supported slash command is:
/format
: automatically format and lint the code