WIP refactor state in singleton #3
Conversation
|
Hello @constantinpape! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2023-10-25 08:06:55 UTC |
| from .annotator_tracking import annotator_tracking | ||
| from .image_series_annotator import image_folder_annotator, image_series_annotator | ||
| # from .annotator import annotator | ||
| # from .annotator_2d import annotator_2d |
There was a problem hiding this comment.
Why are these lines commented out?
This is what causedtest_gui.py to fail, since it used to do from micro_sam.sam_annotator import annotator_2d. I've changed the import in test_gui.py to now say from micro_sam.sam_annotator.annotator_2d import annotator_2d. So now it should pass, regardless of whatever you decide to do here.
There was a problem hiding this comment.
I had to comment these out locally in order to fix the vigra import issues.
There was a problem hiding this comment.
Feel free to undo these changes. I assume these import errors are specific to my installation and I will look into this more closely at some later point (and first see if this still persists with a new environment.)
| @@ -0,0 +1,17 @@ | |||
| import napari | |||
| from skimage.data import astronaut | |||
| from micro_sam.sam_annotator._state import SamState | |||
There was a problem hiding this comment.
Just fyi, I have called this AnnotatorState in computational-cell-analytics#240 now.
No description provided.