Feature/trash dir #46
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
essenciary
reviewed
May 11, 2023
| @@ -286,6 +290,8 @@ function unwatch(path, appid) | |||
| end | |||
|
|
|||
| function start(app) | |||
| @info "inside start" | |||
There was a problem hiding this comment.
Can you remove all these debug messages please
essenciary
reviewed
May 11, 2023
| app_path = joinpath(from_folder, app.name) | ||
|
|
||
| if !isdir(app_path) | ||
| @error "File '$app' is not a directory." |
There was a problem hiding this comment.
Shouldn't this rethrow and break? This will just continue even if the dir does not exist...
essenciary
reviewed
May 11, 2023
|
|
||
| if(isdir(joinpath(to_folder, app.name))) | ||
| timestamp = now() |> (dt -> trunc(dt, Minute)) |> (dt -> Dates.format(dt, "yyyy-mm-ddTHH:MM")) |> (s -> replace(s, r"[-:]" => "")) | ||
| app_new_name = app.name * timestamp |
There was a problem hiding this comment.
Here we should have a separator between app name and timestamp, like __ so we can split/undo the change.
|
@AbhimanyuAryan How do we handle the restore? When we undelete an app - it should reverse the changes. Move out of trash, remove timestamp from app name, etc. |
|
can merge ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tested on windows/macOS. Can be merged