Force fullscreen when using the KMSDRM video driver #4645
Conversation
The KMSDRM video driver switches to a low resolution unless fullscreen is enabled - so we force it in that case. We also ignore any requests to switch to "windowed" mode.
On my laptop, if I switch to a console (Ctrl+Alt+F1), and I run scrcpy, it does not change the resolution (but I can't control anything, keyboard and mouse input are not captured).
What if you start fullscreen then disable fullscreen, does it switch to 800x600? |
|
Note: it seems I misremembered, it actually switches to 640x480, which is the smallest resolution supported by my monitor. I just tried testing stock scrcpy again, it seems to be pretty hit or miss. On my first test, it changed the resolution, but worked fine otherwise. After that, it would always get stuck at
This could be specific to some systems then... Maybe just Raspberry Pis? Would be great if somebody could help us test that hypothesis.
For me, whether the resolution changes or not, input is still captured. When running in a virtual console SDL2 uses evdev for input, so the user must be in the
Yes, it does. |
When running from a virtual console on a Raspberry Pi Zero 2W, SDL will use the KMSDRM video driver. Without any extra options, it automatically switches to
800x600640x480, while the--fullscreenflag keeps the current resolution.This patch automatically enables fullscreen (and prevents it from being disabled) if the KMSDRM driver is used.
PS: I couldn't test on other systems at the moment, so I'd also like some help in testing whether this behavior is present on other systems and whether this patch fixes it.