Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored module layout and corrected formatting lint errors #50

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

cppmonkey
Copy link
Contributor

@cppmonkey cppmonkey commented Feb 26, 2020

Utilising Ansible-Lint v4.2, various warnings have been cleared.

Tested by running, with my fork within ~/.ansible/roles/geonode.geonode-unwind
$ ansible-lint geonode.yml

---
- hosts: webservers
  remote_user: ubuntu
  vars:
    app_name: my_geonode
    github_user: GeoNode
  roles:
    - { role: geonode.geonode-unwind }

tasks, hosts and connection settings have been commented out in tasks/dbservers.yml and delete_dbservers.yml

A number of sections have been expanded to improve maintainability.
Functionality hasn't been changed

@afabiani afabiani requested review from kalxas and t-book February 26, 2020 09:54
@cppmonkey cppmonkey changed the title Refactored module layout and corrected lint errors Refactored module layout and corrected formatting lint errors Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants