Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for model cropping within tide modelling functions #1249

Merged
merged 2 commits into from
Jul 22, 2024

Conversation

robbibt
Copy link
Member

@robbibt robbibt commented Jul 22, 2024

Proposed changes

This PR adds support for pyTMD's new "crop" functionality, which provides on-the-fly cropping of tide model constituent files to improve tide modelling speed (less data = faster tide modelling).

Checklist

(Replace [ ] with [x] to check off)

  • Remove any unused Python packages from Load packages
  • Ensure that all code cells follow the PEP8 standard for code. The jupyterlab_code_formatter tool can be used to format code cells to a consistent style: select each code cell, then click Edit and then one of the Apply X Formatter options (YAPF or Black are recommended).
  • Check for any spelling mistakes using the DEA Sandbox's built-in spellchecker (double click on markdown cells then right-click on pink highlighted words). For example:

sandbox_spellchecker

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Collaborator

@erialC-P erialC-P left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! This will improve efficiency across a whole bunch of workflows I think!

@erialC-P erialC-P merged commit 1b98fd7 into develop Jul 22, 2024
1 check passed
@erialC-P erialC-P deleted the tides_crop branch July 22, 2024 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants