Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding global SAR access through microsoft planetary compute #1263

Merged
merged 3 commits into from
Sep 3, 2024

Conversation

abradley60
Copy link
Collaborator

Proposed changes

Include a brief description of the changes being proposed, and why they are necessary.

Closes issues (optional)

  • Closes Issue #000

Checklist

(Replace [ ] with [x] to check off)

  • Notebook created using the DEA-notebooks template
  • Remove any unused Python packages from Load packages
  • Remove any unused/empty code cells
  • Remove any guidance cells (e.g. General advice)
  • Ensure that all code cells follow the PEP8 standard for code. The jupyterlab_code_formatter tool can be used to format code cells to a consistent style: select each code cell, then click Edit and then one of the Apply X Formatter options (YAPF or Black are recommended).
  • Include relevant tags in the final notebook cell (refer to the DEA Tags Index, and re-use tags if possible)
  • Clear all outputs, run notebook from start to finish, and save the notebook in the state where all cells have been sequentially evaluated
  • Test notebook on both the NCI and DEA Sandbox (flag if not working as part of PR and ask for help to solve if needed)
  • If applicable, update the Notebook currently compatible with the NCI|DEA Sandbox environment only line below the notebook title to reflect the environments the notebook is compatible with
  • Check for any spelling mistakes using the DEA Sandbox's built-in spellchecker (double click on markdown cells then right-click on pink highlighted words). For example:

sandbox_spellchecker

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@abradley60
Copy link
Collaborator Author

@geoscience-aman this has both of our changes. Can you confirm it looks good? Also, will this be cloned down to users sandbox's on login during the session? Or does another branch get clones?

@geoscience-aman
Copy link
Collaborator

@geoscience-aman this has both of our changes. Can you confirm it looks good? Also, will this be cloned down to users sandbox's on login during the session? Or does another branch get clones?

Has my changes and looks good to me! I have made a commit with minor formatting improvements.

I think it's the stable branch that gets cloned. Can you please confirm @robbibt?

@robbibt
Copy link
Member

robbibt commented Sep 3, 2024

Hey @geoscience-aman @abradley60, the Sandbox sync comes from stable - once this PR is merged into develop, we can aim to merge develop into stable ASAP so it will sync automatically!

@@ -2309,11 +2309,663 @@
"metadata": {},
Copy link
Member

@robbibt robbibt Sep 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line #1.    # Search the STAC Catalog

No need for this; only required for datacube access


Reply via ReviewNB

@@ -2309,11 +2309,663 @@
"metadata": {},
Copy link
Member

@robbibt robbibt Sep 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line #5.        #bands=["vv"],

Maybe remove?


Reply via ReviewNB

@@ -2309,11 +2309,663 @@
"metadata": {},
Copy link
Member

@robbibt robbibt Sep 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line #2.    ds_s1["vh_dB"] = 10 * np.log10(ds_s1.vh)

I think @geoscience-aman hada function for applying this step? If so, could be good to use that here too


Reply via ReviewNB

@robbibt
Copy link
Member

robbibt commented Sep 3, 2024

Hey @abradley60, left some tiny comments, if you can fix these up I can approve and we can merge this in!

@robbibt robbibt self-requested a review September 3, 2024 03:05
Copy link
Member

@robbibt robbibt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@robbibt robbibt merged commit 0c4268d into develop Sep 3, 2024
1 check passed
@robbibt robbibt deleted the radar-water-notebook branch September 3, 2024 03:06
geoscience-aman added a commit that referenced this pull request Sep 4, 2024
* Fix deprecation warnings and speed up code

* Change last modified date

* Intertidal exposure (#1261)

* New files for intertidal exposure notebook

* minor editing to Load packages cells

* Updated discord and removed slack links

* Improved markdown linking to image and gif in Introduction

* Incorporated SS and MA reviews

* Updated to include RBT reviews

* Minor pip install and notebook naming edits. Add notebook to README

* adding renamed exposure notebook back into PR

* adding global SAR access through microsoft planetary compute (#1263)

* adding global SAR access through microsoft planetary compute

* Make minor spelling and formatting amendments.

* small changes for PR

---------

Co-authored-by: geoscience-aman <[email protected]>

---------

Co-authored-by: Aman Chopra <[email protected]>
Co-authored-by: geoscience-aman <[email protected]>
Co-authored-by: ClaireP <[email protected]>
Co-authored-by: Alex Bradley <[email protected]>
robbibt added a commit that referenced this pull request Oct 9, 2024
* Fix deprecation warnings and speed up code

* Change last modified date

* Intertidal exposure (#1261)

* New files for intertidal exposure notebook

* minor editing to Load packages cells

* Updated discord and removed slack links

* Improved markdown linking to image and gif in Introduction

* Incorporated SS and MA reviews

* Updated to include RBT reviews

* Minor pip install and notebook naming edits. Add notebook to README

* adding renamed exposure notebook back into PR

* adding global SAR access through microsoft planetary compute (#1263)

* adding global SAR access through microsoft planetary compute

* Make minor spelling and formatting amendments.

* small changes for PR

---------

Co-authored-by: geoscience-aman <[email protected]>

* Update USAGE.rst (#1268)

Add Swinburne course for 2024

* Minor compatibility change for tide modelling package (#1269)

* Mitch predict_xr (#1270)

* add probability array output to predict_xr

* predict_xr at proba_max args

* predict_xr match arg names

* xr_predict deal with multiband prob outout

* xr_predict merge output probs

* clean up comments and spacing

* Update USAGE.rst (#1272)

Add new reference, Burton et al 2024 Enhancing long-term vegetation monitoring in Australia: a new approach for harmonising the Advanced Very High Resolution Radiometer normalised-difference vegetation (NVDI) with MODIS NDVI

* Fix broken code on `unstable` Sandbox image (#1274)

* Updates for pyTMD

* Fix contours bug due to groupby squeeze

* Try loosening pyTMD requirements

* Update tests to pass on both stable and unstable sandbox

* Fix pansharpening bug

---------

Co-authored-by: Aman Chopra <[email protected]>
Co-authored-by: geoscience-aman <[email protected]>
Co-authored-by: ClaireP <[email protected]>
Co-authored-by: Alex Bradley <[email protected]>
Co-authored-by: Bex Dunn <[email protected]>
Co-authored-by: Mitchell Lyons <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants