Skip to content

Commit

Permalink
Merge pull request storybookjs#29451 from storybookjs/story-status-me…
Browse files Browse the repository at this point in the history
…nu-checkmark

Core: Show checkmark icon in story status dropdown and update status label for component tests
  • Loading branch information
valentinpalkovic authored Oct 28, 2024
2 parents 6098c01 + 8b08b4e commit 936293d
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
2 changes: 1 addition & 1 deletion code/addons/test/src/manager.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ addons.register(ADDON_ID, (api) => {
.map(({ storyId, status, testRunId, ...rest }) => {
if (storyId) {
const statusObject: API_StatusObject = {
title: 'Vitest',
title: 'Component tests',
status: statusMap[status],
description:
'failureMessages' in rest && rest.failureMessages?.length
Expand Down
3 changes: 2 additions & 1 deletion code/core/src/manager/components/sidebar/Tree.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import {
CollapseIcon as CollapseIconSvg,
ExpandAltIcon,
StatusFailIcon,
StatusPassIcon,
StatusWarnIcon,
SyncIcon,
} from '@storybook/icons';
Expand Down Expand Up @@ -224,7 +225,7 @@ const Node = React.memo<NodeProps>(function Node({
description: value.description,
'aria-label': `Test status for ${value.title}: ${value.status}`,
icon: {
success: null, // We don't show a checkmark, to avoid clutter
success: <StatusPassIcon color={theme.color.positive} />,
error: <StatusFailIcon color={theme.color.negative} />,
warn: <StatusWarnIcon color={theme.color.warning} />,
pending: <SyncIcon size={12} color={theme.color.defaultText} />,
Expand Down

0 comments on commit 936293d

Please sign in to comment.