-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keeps search state on post, allow order by column #80
base: master
Are you sure you want to change the base?
Conversation
Fixes iframe height calculation Fixes sortable hover-style
I have looked at the PR and it has several significant issues:
Because of these issues, I cannot accept this PR, but it could be a reference for a new PR without these issues. Although, I would discuss first how it should be implemented in the issue #73 before doing anything. |
The problem with current implemenation, in addition to the bad user experience, is that you fetch all posts instead of pagination on database side. A removed third party dependency for just calculating number of pages is not such a bad thing. Regarding public interfaces. Current methods can be kept with a redirect to the new implementation. One would have to keep paged list then though and remap a ”fetch all” to this. If you want to keep state with get state needs to be kept in sync manually for all different kinds of filters/query you add. Using post all together makes this work seemlessly. But probably can keep this in sync with js then. Aka updating hidden field with current query. One perhaps can wrap it with a get-form and trigger the posts in a different way without introducing any form nesting… |
If I tried to work around these issues could you have another look or is that just wasted time? |
Maybe the best would be so that this PR would be a reference for multiple other PRs. I will go through the PR and comment on parts that should be pushed separately. And also could comment on parts of how to change public interfaces and other stuff. |
...undHandler.Optimizely/Geta.NotFoundHandler.Optimizely.Views/Views/Shared/_ShellLayout.cshtml
Outdated
Show resolved
Hide resolved
Now public interfaces are restored and GET:s and POST:s are separated. |
As mentioned earlier, we should use this PR as a reference for multiple smaller PRs. Inspired by your work, I moved the sortable headers into a separate PR and adjusted the code. |
Partial #73
Fixes #117
I've rewritten the fetching for suggestions and redirects to allow it to store search state on delete / page change.
I also added the possibilty to sort the columns.
I also added pagination to the sql-fetching
and by that also removed dependency to X.PagedList. Dependency on PagedList kept for backward compability.Added confirmation message on operations, which fixes #13