-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show modal in same position (height) as trigger of modal #81
base: master
Are you sure you want to change the base?
Conversation
Not sure what to to with the build failing, tests seems to pass but I think your sonar-configuration is off. Seems to have to do with the build being processed on my fork where the secret is missing: |
The build fails for the reason you wrote. Please ignore it. |
I don’t think it wont be doable with css only because the iframe viewport. It’s if bootstrap has some js to automatically apply it. Basically this still applies (a quick google): |
You are right. Bootstrap already sets it in the center, but the issue is that it is in an iframe. |
Fixes #72
Had to do a bit of a workaround since the table / modal is within an iframe so not easily fixed by only css.
Either way the modal is now positioned based on the offset height of the button which triggered it.