Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show modal in same position (height) as trigger of modal #81

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

ellinge
Copy link
Contributor

@ellinge ellinge commented Feb 10, 2023

Fixes #72

Had to do a bit of a workaround since the table / modal is within an iframe so not easily fixed by only css.

Either way the modal is now positioned based on the offset height of the button which triggered it.

image

@ellinge
Copy link
Contributor Author

ellinge commented Feb 10, 2023

Not sure what to to with the build failing, tests seems to pass but I think your sonar-configuration is off.

Seems to have to do with the build being processed on my fork where the secret is missing:
https://community.sonarsource.com/t/sonarcloud-analysis-fails-on-prs-for-c-project-on-github/34260

https://portal.productboard.com/sonarsource/1-sonarcloud/c/50-sonarcloud-analyzes-external-pull-request

@marisks
Copy link
Member

marisks commented Feb 17, 2023

The build fails for the reason you wrote. Please ignore it.
Regarding the changes, the fix should be possible without JS and just with CSS. Also, it would be good to update Bootstrap to the release version (now it uses Beta) before applying the fix - it might fix the issue.
I will take a look at it.
If none of it will help, then this PR will be accepted.

@ellinge
Copy link
Contributor Author

ellinge commented Feb 17, 2023

I don’t think it wont be doable with css only because the iframe viewport. It’s if bootstrap has some js to automatically apply it.

Basically this still applies (a quick google):
https://stackoverflow.com/questions/8061728/fix-an-element-inside-an-iframe-in-the-center-of-the-screen

@marisks
Copy link
Member

marisks commented Feb 17, 2023

You are right. Bootstrap already sets it in the center, but the issue is that it is in an iframe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suggestions - Referreres popup get's centered in the middle of the list
2 participants