Release/4.3.0 #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d filters that are in v10 version
tristanjthompson
requested review from
stevetemple,
aheaford,
ThomasAdams2 and
MDuncan98
tristanjthompson
force-pushed
the
release/4.3.0
branch
from
8207367 to
f6b2bb5
Compare
Reaction77
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For BR we're making the blog headless. In order to serialize the
IBlogPostFilter/ISortclasses to JSON, we need to expose the private fields. I originally was using reflection for this to save updating the v7 & v10 packages, but after chatting to @aheaford we decided to bite the bullet and change both packages.We've already done this in the v10 version in these commits in PR Gibe/Gibe.Umbraco.Blog#30
The guts of the changes are: