Skip to content

Commit

Permalink
Merge branch 'feat/PG-1411' of github.com:Giphy/giphy-js into feat/PG…
Browse files Browse the repository at this point in the history
…-1411
  • Loading branch information
nicksantan committed Apr 30, 2024
2 parents eebcad0 + e436a4e commit c6ba8ed
Show file tree
Hide file tree
Showing 7 changed files with 197 additions and 206 deletions.
5 changes: 0 additions & 5 deletions .changeset/light-tools-change.md

This file was deleted.

5 changes: 0 additions & 5 deletions .changeset/swift-owls-sin.md

This file was deleted.

9 changes: 9 additions & 0 deletions .changeset/warm-baboons-fold.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
---
'@giphy/react-components': minor
'@giphy/js-components': minor
'@giphy/js-fetch-api': minor
'@giphy/js-types': minor
'@giphy/js-util': minor
---

Readded MOAT tracking to react-sdk
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
},
"private": true,
"devDependencies": {
"@changesets/cli": "^2.26.1",
"@changesets/cli": "^2.27.1",
"@types/jest": "^29.5.1",
"@types/node": "^20.1.2",
"@typescript-eslint/eslint-plugin": "^5.59.5",
Expand Down
4 changes: 2 additions & 2 deletions packages/components/src/components/gif.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -168,8 +168,8 @@ const Gif = ({
}
const trackWithMoat = async () => {
if (shouldShowMedia && container.current) {
const { bottle_data: bottleData, response_id } = gif
const moatCompatibleData = constructMoatData(bottleData as any)
const { bottle_data, response_id } = gif
const moatCompatibleData = constructMoatData(bottle_data as any)
if (moatCompatibleData) {
moatCompatibleData.zMoatSession = response_id
await moatLoader
Expand Down
7 changes: 1 addition & 6 deletions packages/types/src/gif.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,6 @@ import { IImages } from './images'
import IUser from './user'
import IVideo from './video'

interface IBottleData {
tid?: string
tags?: string[]
}

export type GifID = string | number

export default interface IGif {
Expand Down Expand Up @@ -34,7 +29,7 @@ export default interface IGif {
is_scheduled: boolean
is_removed: boolean
tags: string[]
bottle_data: IBottleData
bottle_data: any
response_id: string
analytics_response_payload: string
video?: IVideo
Expand Down
Loading

0 comments on commit c6ba8ed

Please sign in to comment.