Make an exception with _3d import on QGS101 and QGS102 #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Usually QGS101 or QGS102 is thrown when importing _ prefixed modules. _3d is currently an exception to this rule, so we should not throw an error when importing it. Importing just 3d would throw and SyntaxError because 3d is not a valid package name because of the leading digit. _3d is the only way to use the 3d module.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should be merged after #10.
Usually QGS101 or QGS102 is thrown when importing _ prefixed modules.
_3d is currently an exception to this rule, so we should not throw an
error when importing it. Importing just 3d would throw and SyntaxError
because 3d is not a valid package name because of the leading digit.
_3d is the only way to use the 3d module.
Resolves: #9