This repository has been archived by the owner on Sep 20, 2023. It is now read-only.
Fix notification bug #2689
Open
Fix notification bug #2689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BasThomas
reviewed
Mar 14, 2019
| @@ -33,6 +33,10 @@ RouterPropsSource { | |||
| sessionManager.addListener(listener: self) | |||
| } | |||
|
|
|||
| func getAppClient() -> GithubClient? { | |||
There was a problem hiding this comment.
This feels a bit weird to me... think it would be nice if we can keep the reading logic in one place.
There was a problem hiding this comment.
No problem so how should I get the app client in the extension?
There was a problem hiding this comment.
Hm, that's a question I don't know I can answer :(
There was a problem hiding this comment.
I can make it public or create a getter, or I could move the extension into the main class
There was a problem hiding this comment.
I feel like option 3 would be the best for now.
Huddie
added
😴 awaiting changes
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2298
@BasThomas let me know if this makes sense.
Issue:
Tapping notification to open issue doesn't mark the notification read
Solution:
Notification ID is passed apart of the request when creating local notification. Before routing to the Issue, extract the ID and mark the notification as read.
We are marking notifications are read before actually displaying the notification but this no different than how it works when tapping on a note. in the inbox.
Possible enhancement:
We have some redundant code here. The
markNotificationReadmethod shows up here and inNotificationModelControllersuggestions are welcome as to where the best place to put it is. Keep in mind if we refactor both methods we will need to pass in theGithubClientwhich isn't great.