Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QF - Improve sorting for QF rounds #2942

Closed
laurenluz opened this issue Jul 17, 2023 · 18 comments
Closed

QF - Improve sorting for QF rounds #2942

laurenluz opened this issue Jul 17, 2023 · 18 comments
Assignees
Labels
QF Quadratic Funding Related

Comments

@laurenluz
Copy link
Member

We should improve the sorting on QF rounds to accomodate QF rounds. So on the QF page, it would be great to sort by:

  • "$ Raised this QF round" - this sorts the projects according to the total funding they raised in the current QF round

is that title too long? @MohammadPCh

@divine-comedian divine-comedian added the QF Quadratic Funding Related label Jul 19, 2023
@divine-comedian
Copy link
Contributor

This needs to implemented on the back-end first and then we can update the front-end

@laurenluz
Copy link
Member Author

Should add:

  • Sort by amount donated in this QF round

@CarlosQ96 - can you work on the backend this week?

@CarlosQ96
Copy link
Collaborator

CarlosQ96 commented Aug 2, 2023

Ill leave a pr for this tomorrow. Working on Joining the view

@MoeNick
Copy link
Member

MoeNick commented Aug 16, 2023

Can you update us on this issue @CarlosQ96 ?

@CarlosQ96
Copy link
Collaborator

Hey added the filters and added some tests. However it's getting conflict in database results when executing due to many tables we query at the same time.

Trying to avoid a big rewrite. But seems limitation of the db framework. Spent many hours on it today, will try a few more things tomorrow and update this issue properly.

@MoeNick
Copy link
Member

MoeNick commented Sep 11, 2023

@mohammadranjbarz and @CarlosQ96 may meet about it.

@laurenluz
Copy link
Member Author

@CarlosQ96 - you're working on this this week, right? would be nice to have before the Optimism round starts (which might be as early as Oct 4)

@CarlosQ96
Copy link
Collaborator

Yeah i should be done between today and friday, working on a new table that has the current round sums and data.

@maryjaf
Copy link
Collaborator

maryjaf commented Sep 28, 2023

Should this issue be implemented for optimism round ? @laurenluz @CarlosQ96

@CarlosQ96
Copy link
Collaborator

Giveth/impact-graph#1137

@laurenluz
Copy link
Member Author

Should this issue be implemented for optimism round ? @laurenluz @CarlosQ96

@maryjaf - yes please! let's test it :)

@maryjaf
Copy link
Collaborator

maryjaf commented Oct 3, 2023

It hasn't been merged, I'll test it with high priority when it will be ready for testing

@maryjaf
Copy link
Collaborator

maryjaf commented Oct 5, 2023

The projects that haven't been received donation in a round isn't shown by this new sorting, plz check @CarlosQ96

@CarlosQ96
Copy link
Collaborator

Ok Found the bug ill push hotfix

@CarlosQ96
Copy link
Collaborator

pushed hotfix , issue corrected.

@maryjaf
Copy link
Collaborator

maryjaf commented Oct 5, 2023

It seems sth is wrong , by setting "Amount Raised in QF" the projects with 0 amount raised are shown in the first position
Private Zenhub Image
@CarlosQ96

@CarlosQ96
Copy link
Collaborator

@laurenluz @maryjaf Fixed order!

@maryjaf
Copy link
Collaborator

maryjaf commented Oct 7, 2023

It seems sth is wrong , by setting "Amount Raised in QF" the projects with 0 amount raised are shown in the first position

Thanks @CarlosQ96 This problem has been resolve

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QF Quadratic Funding Related
Projects
None yet
Development

No branches or pull requests

6 participants