Add qfFilter with estimatedMatchingView #1137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CarlosQ96
force-pushed
the
feature_new_qf_filters_table
branch
from
ebd2f4e to
84a8bf0
Compare
|
@mohammadranjbarz ready for review Its a filtered sort, per talking with @laurenluz |
CarlosQ96
force-pushed
the
feature_new_qf_filters_table
branch
from
4b3474e to
3620351
Compare
mohammadranjbarz
approved these changes
Oct 3, 2023
There was a problem hiding this comment.
Thanks @CarlosQ96 LGTM
but I dont know with changing the ProjectEstimatedMAtchingView.ts file don't you need to write a migration to change the view in DB?
if we need it please add migration otherwise feel free to merge it
|
@mohammadranjbarz they were mostly annotations that were missing, it should be safe to merge as we don't synchronize the entities. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to Giveth/giveth-dapps-v2#2942