Skip to content

Commit

Permalink
removed AngleSigned
Browse files Browse the repository at this point in the history
  • Loading branch information
Givikap120 committed May 5, 2024
1 parent 325e18d commit f06bdef
Showing 1 changed file with 2 additions and 10 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -80,19 +80,12 @@ public class OsuDifficultyHitObject : DifficultyHitObject
public double TravelTime { get; private set; }

/// <summary>
/// Absolute angle the player has to take to hit this <see cref="OsuDifficultyHitObject"/>.
/// Angle the player has to take to hit this <see cref="OsuDifficultyHitObject"/>.
/// Calculated as the angle between the circles (current-2, current-1, current).
/// Ranges from 0 to PI
/// </summary>
public double? Angle { get; private set; }

/// <summary>
/// Signed version of the Angle.
/// Potentially should be used for more accurate angle bonuses
/// Ranges from -PI to PI
/// </summary>
public double? AngleSigned { get; private set; }

/// <summary>
/// Retrieves the full hit window for a Great <see cref="HitResult"/>.
/// </summary>
Expand Down Expand Up @@ -516,8 +509,7 @@ private void setDistances(double clockRate)
float dot = Vector2.Dot(v1, v2);
float det = v1.X * v2.Y - v1.Y * v2.X;

AngleSigned = Math.Atan2(det, dot);
Angle = Math.Abs((double)AngleSigned);
Angle = Math.Abs(Math.Atan2(det, dot));
}
}

Expand Down

0 comments on commit f06bdef

Please sign in to comment.