Skip to content

fixed FL bonus being added always #319

fixed FL bonus being added always

fixed FL bonus being added always #319

GitHub Actions / Test Results (Windows, MultiThreaded) failed Sep 10, 2024 in 0s

10459 passed, 10 failed and 74 skipped

Tests failed

❌ TestResults-Windows-MultiThreaded.trx

10543 tests were completed in 2902s with 10459 passed, 10 failed and 74 skipped.

Test suite Passed Failed Skipped Time
osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest 10❌ 73ms

❌ osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest

❌ Test(0.14102693012101306d,2,"nan-slider")
	  Expected: 0.14102693012101306d +/- 1.0000000000000001E-05d
	  But was:  0.14534031702030198d
	  Off by:   -0.0043133868992889235d
	
❌ Test(0.4250648023083879d,4,"very-fast-slider")
	  Expected: 0.42506480230838789d +/- 1.0000000000000001E-05d
	  But was:  0.42092105878578351d
	  Off by:   0.0041437435226043817d
	
❌ Test(1.4386882251130073d,54,"zero-length-sliders")
	  Expected: 1.4386882251130073d +/- 1.0000000000000001E-05d
	  But was:  1.4239506189830415d
	  Off by:   0.014737606129965775d
	
❌ Test(6.710442985146793d,239,"diffcalc-test")
	  Expected: 6.710442985146793d +/- 1.0000000000000001E-05d
	  But was:  6.9119045716220064d
	  Off by:   -0.20146158647521339d
	
❌ TestClassicMod(0.4250648023083879d,4,"very-fast-slider")
	  Expected: 0.42506480230838789d +/- 1.0000000000000001E-05d
	  But was:  0.42092105878578351d
	  Off by:   0.0041437435226043817d
	
❌ TestClassicMod(1.4386882251130073d,54,"zero-length-sliders")
	  Expected: 1.4386882251130073d +/- 1.0000000000000001E-05d
	  But was:  1.4239506189830415d
	  Off by:   0.014737606129965775d
	
❌ TestClassicMod(6.710442985146793d,239,"diffcalc-test")
	  Expected: 6.710442985146793d +/- 1.0000000000000001E-05d
	  But was:  6.9119045716220064d
	  Off by:   -0.20146158647521339d
	
❌ TestClockRateAdjusted(0.5507108280047351d,4,"very-fast-slider")
	  Expected: 0.55071082800473514d +/- 1.0000000000000001E-05d
	  But was:  1.3523484449437511d
	  Off by:   -0.80163761693901592d
	
❌ TestClockRateAdjusted(1.743180218215227d,54,"zero-length-sliders")
	  Expected: 1.743180218215227d +/- 1.0000000000000001E-05d
	  But was:  1.7252763477714828d
	  Off by:   0.017903870443744196d
	
❌ TestClockRateAdjusted(8.974295270307167d,239,"diffcalc-test")
	  Expected: 8.9742952703071666d +/- 1.0000000000000001E-05d
	  But was:  9.0856072300355262d
	  Off by:   -0.11131195972835961d
	

Annotations

Check failure on line 31 in osu.Game/Tests/Beatmaps/DifficultyCalculatorTest.cs

See this annotation in the file changed.

@github-actions github-actions / Test Results (Windows, MultiThreaded)

osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest ► Test(0.14102693012101306d,2,"nan-slider")

Failed test found in:
  TestResults-Windows-MultiThreaded.trx
Error:
    Expected: 0.14102693012101306d +/- 1.0000000000000001E-05d
    But was:  0.14534031702030198d
    Off by:   -0.0043133868992889235d
  
Raw output
  Expected: 0.14102693012101306d +/- 1.0000000000000001E-05d
  But was:  0.14534031702030198d
  Off by:   -0.0043133868992889235d

   at osu.Game.Tests.Beatmaps.DifficultyCalculatorTest.Test(Double expectedStarRating, Int32 expectedMaxCombo, String name, Mod[] mods) in D:\a\osu\osu\osu.Game\Tests\Beatmaps\DifficultyCalculatorTest.cs:line 31
   at osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest.Test(Double expectedStarRating, Int32 expectedMaxCombo, String name) in D:\a\osu\osu\osu.Game.Rulesets.Osu.Tests\OsuDifficultyCalculatorTest.cs:line 23
   at InvokeStub_OsuDifficultyCalculatorTest.Test(Object, Span`1)

1)    at osu.Game.Tests.Beatmaps.DifficultyCalculatorTest.Test(Double expectedStarRating, Int32 expectedMaxCombo, String name, Mod[] mods) in D:\a\osu\osu\osu.Game\Tests\Beatmaps\DifficultyCalculatorTest.cs:line 31
   at osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest.Test(Double expectedStarRating, Int32 expectedMaxCombo, String name) in D:\a\osu\osu\osu.Game.Rulesets.Osu.Tests\OsuDifficultyCalculatorTest.cs:line 23
   at InvokeStub_OsuDifficultyCalculatorTest.Test(Object, Span`1)

Check failure on line 31 in osu.Game/Tests/Beatmaps/DifficultyCalculatorTest.cs

See this annotation in the file changed.

@github-actions github-actions / Test Results (Windows, MultiThreaded)

osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest ► Test(0.4250648023083879d,4,"very-fast-slider")

Failed test found in:
  TestResults-Windows-MultiThreaded.trx
Error:
    Expected: 0.42506480230838789d +/- 1.0000000000000001E-05d
    But was:  0.42092105878578351d
    Off by:   0.0041437435226043817d
  
Raw output
  Expected: 0.42506480230838789d +/- 1.0000000000000001E-05d
  But was:  0.42092105878578351d
  Off by:   0.0041437435226043817d

   at osu.Game.Tests.Beatmaps.DifficultyCalculatorTest.Test(Double expectedStarRating, Int32 expectedMaxCombo, String name, Mod[] mods) in D:\a\osu\osu\osu.Game\Tests\Beatmaps\DifficultyCalculatorTest.cs:line 31
   at osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest.Test(Double expectedStarRating, Int32 expectedMaxCombo, String name) in D:\a\osu\osu\osu.Game.Rulesets.Osu.Tests\OsuDifficultyCalculatorTest.cs:line 23
   at InvokeStub_OsuDifficultyCalculatorTest.Test(Object, Span`1)

1)    at osu.Game.Tests.Beatmaps.DifficultyCalculatorTest.Test(Double expectedStarRating, Int32 expectedMaxCombo, String name, Mod[] mods) in D:\a\osu\osu\osu.Game\Tests\Beatmaps\DifficultyCalculatorTest.cs:line 31
   at osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest.Test(Double expectedStarRating, Int32 expectedMaxCombo, String name) in D:\a\osu\osu\osu.Game.Rulesets.Osu.Tests\OsuDifficultyCalculatorTest.cs:line 23
   at InvokeStub_OsuDifficultyCalculatorTest.Test(Object, Span`1)

Check failure on line 31 in osu.Game/Tests/Beatmaps/DifficultyCalculatorTest.cs

See this annotation in the file changed.

@github-actions github-actions / Test Results (Windows, MultiThreaded)

osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest ► Test(1.4386882251130073d,54,"zero-length-sliders")

Failed test found in:
  TestResults-Windows-MultiThreaded.trx
Error:
    Expected: 1.4386882251130073d +/- 1.0000000000000001E-05d
    But was:  1.4239506189830415d
    Off by:   0.014737606129965775d
  
Raw output
  Expected: 1.4386882251130073d +/- 1.0000000000000001E-05d
  But was:  1.4239506189830415d
  Off by:   0.014737606129965775d

   at osu.Game.Tests.Beatmaps.DifficultyCalculatorTest.Test(Double expectedStarRating, Int32 expectedMaxCombo, String name, Mod[] mods) in D:\a\osu\osu\osu.Game\Tests\Beatmaps\DifficultyCalculatorTest.cs:line 31
   at osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest.Test(Double expectedStarRating, Int32 expectedMaxCombo, String name) in D:\a\osu\osu\osu.Game.Rulesets.Osu.Tests\OsuDifficultyCalculatorTest.cs:line 23
   at InvokeStub_OsuDifficultyCalculatorTest.Test(Object, Span`1)

1)    at osu.Game.Tests.Beatmaps.DifficultyCalculatorTest.Test(Double expectedStarRating, Int32 expectedMaxCombo, String name, Mod[] mods) in D:\a\osu\osu\osu.Game\Tests\Beatmaps\DifficultyCalculatorTest.cs:line 31
   at osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest.Test(Double expectedStarRating, Int32 expectedMaxCombo, String name) in D:\a\osu\osu\osu.Game.Rulesets.Osu.Tests\OsuDifficultyCalculatorTest.cs:line 23
   at InvokeStub_OsuDifficultyCalculatorTest.Test(Object, Span`1)

Check failure on line 31 in osu.Game/Tests/Beatmaps/DifficultyCalculatorTest.cs

See this annotation in the file changed.

@github-actions github-actions / Test Results (Windows, MultiThreaded)

osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest ► Test(6.710442985146793d,239,"diffcalc-test")

Failed test found in:
  TestResults-Windows-MultiThreaded.trx
Error:
    Expected: 6.710442985146793d +/- 1.0000000000000001E-05d
    But was:  6.9119045716220064d
    Off by:   -0.20146158647521339d
  
Raw output
  Expected: 6.710442985146793d +/- 1.0000000000000001E-05d
  But was:  6.9119045716220064d
  Off by:   -0.20146158647521339d

   at osu.Game.Tests.Beatmaps.DifficultyCalculatorTest.Test(Double expectedStarRating, Int32 expectedMaxCombo, String name, Mod[] mods) in D:\a\osu\osu\osu.Game\Tests\Beatmaps\DifficultyCalculatorTest.cs:line 31
   at osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest.Test(Double expectedStarRating, Int32 expectedMaxCombo, String name) in D:\a\osu\osu\osu.Game.Rulesets.Osu.Tests\OsuDifficultyCalculatorTest.cs:line 23

1)    at osu.Game.Tests.Beatmaps.DifficultyCalculatorTest.Test(Double expectedStarRating, Int32 expectedMaxCombo, String name, Mod[] mods) in D:\a\osu\osu\osu.Game\Tests\Beatmaps\DifficultyCalculatorTest.cs:line 31
   at osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest.Test(Double expectedStarRating, Int32 expectedMaxCombo, String name) in D:\a\osu\osu\osu.Game.Rulesets.Osu.Tests\OsuDifficultyCalculatorTest.cs:line 23

Check failure on line 31 in osu.Game/Tests/Beatmaps/DifficultyCalculatorTest.cs

See this annotation in the file changed.

@github-actions github-actions / Test Results (Windows, MultiThreaded)

osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest ► TestClassicMod(0.4250648023083879d,4,"very-fast-slider")

Failed test found in:
  TestResults-Windows-MultiThreaded.trx
Error:
    Expected: 0.42506480230838789d +/- 1.0000000000000001E-05d
    But was:  0.42092105878578351d
    Off by:   0.0041437435226043817d
  
Raw output
  Expected: 0.42506480230838789d +/- 1.0000000000000001E-05d
  But was:  0.42092105878578351d
  Off by:   0.0041437435226043817d

   at osu.Game.Tests.Beatmaps.DifficultyCalculatorTest.Test(Double expectedStarRating, Int32 expectedMaxCombo, String name, Mod[] mods) in D:\a\osu\osu\osu.Game\Tests\Beatmaps\DifficultyCalculatorTest.cs:line 31
   at osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest.TestClassicMod(Double expectedStarRating, Int32 expectedMaxCombo, String name) in D:\a\osu\osu\osu.Game.Rulesets.Osu.Tests\OsuDifficultyCalculatorTest.cs:line 35
   at InvokeStub_OsuDifficultyCalculatorTest.TestClassicMod(Object, Span`1)

1)    at osu.Game.Tests.Beatmaps.DifficultyCalculatorTest.Test(Double expectedStarRating, Int32 expectedMaxCombo, String name, Mod[] mods) in D:\a\osu\osu\osu.Game\Tests\Beatmaps\DifficultyCalculatorTest.cs:line 31
   at osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest.TestClassicMod(Double expectedStarRating, Int32 expectedMaxCombo, String name) in D:\a\osu\osu\osu.Game.Rulesets.Osu.Tests\OsuDifficultyCalculatorTest.cs:line 35
   at InvokeStub_OsuDifficultyCalculatorTest.TestClassicMod(Object, Span`1)

Check failure on line 31 in osu.Game/Tests/Beatmaps/DifficultyCalculatorTest.cs

See this annotation in the file changed.

@github-actions github-actions / Test Results (Windows, MultiThreaded)

osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest ► TestClassicMod(1.4386882251130073d,54,"zero-length-sliders")

Failed test found in:
  TestResults-Windows-MultiThreaded.trx
Error:
    Expected: 1.4386882251130073d +/- 1.0000000000000001E-05d
    But was:  1.4239506189830415d
    Off by:   0.014737606129965775d
  
Raw output
  Expected: 1.4386882251130073d +/- 1.0000000000000001E-05d
  But was:  1.4239506189830415d
  Off by:   0.014737606129965775d

   at osu.Game.Tests.Beatmaps.DifficultyCalculatorTest.Test(Double expectedStarRating, Int32 expectedMaxCombo, String name, Mod[] mods) in D:\a\osu\osu\osu.Game\Tests\Beatmaps\DifficultyCalculatorTest.cs:line 31
   at osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest.TestClassicMod(Double expectedStarRating, Int32 expectedMaxCombo, String name) in D:\a\osu\osu\osu.Game.Rulesets.Osu.Tests\OsuDifficultyCalculatorTest.cs:line 35
   at InvokeStub_OsuDifficultyCalculatorTest.TestClassicMod(Object, Span`1)

1)    at osu.Game.Tests.Beatmaps.DifficultyCalculatorTest.Test(Double expectedStarRating, Int32 expectedMaxCombo, String name, Mod[] mods) in D:\a\osu\osu\osu.Game\Tests\Beatmaps\DifficultyCalculatorTest.cs:line 31
   at osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest.TestClassicMod(Double expectedStarRating, Int32 expectedMaxCombo, String name) in D:\a\osu\osu\osu.Game.Rulesets.Osu.Tests\OsuDifficultyCalculatorTest.cs:line 35
   at InvokeStub_OsuDifficultyCalculatorTest.TestClassicMod(Object, Span`1)

Check failure on line 31 in osu.Game/Tests/Beatmaps/DifficultyCalculatorTest.cs

See this annotation in the file changed.

@github-actions github-actions / Test Results (Windows, MultiThreaded)

osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest ► TestClassicMod(6.710442985146793d,239,"diffcalc-test")

Failed test found in:
  TestResults-Windows-MultiThreaded.trx
Error:
    Expected: 6.710442985146793d +/- 1.0000000000000001E-05d
    But was:  6.9119045716220064d
    Off by:   -0.20146158647521339d
  
Raw output
  Expected: 6.710442985146793d +/- 1.0000000000000001E-05d
  But was:  6.9119045716220064d
  Off by:   -0.20146158647521339d

   at osu.Game.Tests.Beatmaps.DifficultyCalculatorTest.Test(Double expectedStarRating, Int32 expectedMaxCombo, String name, Mod[] mods) in D:\a\osu\osu\osu.Game\Tests\Beatmaps\DifficultyCalculatorTest.cs:line 31
   at osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest.TestClassicMod(Double expectedStarRating, Int32 expectedMaxCombo, String name) in D:\a\osu\osu\osu.Game.Rulesets.Osu.Tests\OsuDifficultyCalculatorTest.cs:line 35

1)    at osu.Game.Tests.Beatmaps.DifficultyCalculatorTest.Test(Double expectedStarRating, Int32 expectedMaxCombo, String name, Mod[] mods) in D:\a\osu\osu\osu.Game\Tests\Beatmaps\DifficultyCalculatorTest.cs:line 31
   at osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest.TestClassicMod(Double expectedStarRating, Int32 expectedMaxCombo, String name) in D:\a\osu\osu\osu.Game.Rulesets.Osu.Tests\OsuDifficultyCalculatorTest.cs:line 35

Check failure on line 31 in osu.Game/Tests/Beatmaps/DifficultyCalculatorTest.cs

See this annotation in the file changed.

@github-actions github-actions / Test Results (Windows, MultiThreaded)

osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest ► TestClockRateAdjusted(0.5507108280047351d,4,"very-fast-slider")

Failed test found in:
  TestResults-Windows-MultiThreaded.trx
Error:
    Expected: 0.55071082800473514d +/- 1.0000000000000001E-05d
    But was:  1.3523484449437511d
    Off by:   -0.80163761693901592d
  
Raw output
  Expected: 0.55071082800473514d +/- 1.0000000000000001E-05d
  But was:  1.3523484449437511d
  Off by:   -0.80163761693901592d

   at osu.Game.Tests.Beatmaps.DifficultyCalculatorTest.Test(Double expectedStarRating, Int32 expectedMaxCombo, String name, Mod[] mods) in D:\a\osu\osu\osu.Game\Tests\Beatmaps\DifficultyCalculatorTest.cs:line 31
   at osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest.TestClockRateAdjusted(Double expectedStarRating, Int32 expectedMaxCombo, String name) in D:\a\osu\osu\osu.Game.Rulesets.Osu.Tests\OsuDifficultyCalculatorTest.cs:line 29
   at InvokeStub_OsuDifficultyCalculatorTest.TestClockRateAdjusted(Object, Span`1)

1)    at osu.Game.Tests.Beatmaps.DifficultyCalculatorTest.Test(Double expectedStarRating, Int32 expectedMaxCombo, String name, Mod[] mods) in D:\a\osu\osu\osu.Game\Tests\Beatmaps\DifficultyCalculatorTest.cs:line 31
   at osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest.TestClockRateAdjusted(Double expectedStarRating, Int32 expectedMaxCombo, String name) in D:\a\osu\osu\osu.Game.Rulesets.Osu.Tests\OsuDifficultyCalculatorTest.cs:line 29
   at InvokeStub_OsuDifficultyCalculatorTest.TestClockRateAdjusted(Object, Span`1)

Check failure on line 31 in osu.Game/Tests/Beatmaps/DifficultyCalculatorTest.cs

See this annotation in the file changed.

@github-actions github-actions / Test Results (Windows, MultiThreaded)

osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest ► TestClockRateAdjusted(1.743180218215227d,54,"zero-length-sliders")

Failed test found in:
  TestResults-Windows-MultiThreaded.trx
Error:
    Expected: 1.743180218215227d +/- 1.0000000000000001E-05d
    But was:  1.7252763477714828d
    Off by:   0.017903870443744196d
  
Raw output
  Expected: 1.743180218215227d +/- 1.0000000000000001E-05d
  But was:  1.7252763477714828d
  Off by:   0.017903870443744196d

   at osu.Game.Tests.Beatmaps.DifficultyCalculatorTest.Test(Double expectedStarRating, Int32 expectedMaxCombo, String name, Mod[] mods) in D:\a\osu\osu\osu.Game\Tests\Beatmaps\DifficultyCalculatorTest.cs:line 31
   at osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest.TestClockRateAdjusted(Double expectedStarRating, Int32 expectedMaxCombo, String name) in D:\a\osu\osu\osu.Game.Rulesets.Osu.Tests\OsuDifficultyCalculatorTest.cs:line 29
   at InvokeStub_OsuDifficultyCalculatorTest.TestClockRateAdjusted(Object, Span`1)

1)    at osu.Game.Tests.Beatmaps.DifficultyCalculatorTest.Test(Double expectedStarRating, Int32 expectedMaxCombo, String name, Mod[] mods) in D:\a\osu\osu\osu.Game\Tests\Beatmaps\DifficultyCalculatorTest.cs:line 31
   at osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest.TestClockRateAdjusted(Double expectedStarRating, Int32 expectedMaxCombo, String name) in D:\a\osu\osu\osu.Game.Rulesets.Osu.Tests\OsuDifficultyCalculatorTest.cs:line 29
   at InvokeStub_OsuDifficultyCalculatorTest.TestClockRateAdjusted(Object, Span`1)

Check failure on line 31 in osu.Game/Tests/Beatmaps/DifficultyCalculatorTest.cs

See this annotation in the file changed.

@github-actions github-actions / Test Results (Windows, MultiThreaded)

osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest ► TestClockRateAdjusted(8.974295270307167d,239,"diffcalc-test")

Failed test found in:
  TestResults-Windows-MultiThreaded.trx
Error:
    Expected: 8.9742952703071666d +/- 1.0000000000000001E-05d
    But was:  9.0856072300355262d
    Off by:   -0.11131195972835961d
  
Raw output
  Expected: 8.9742952703071666d +/- 1.0000000000000001E-05d
  But was:  9.0856072300355262d
  Off by:   -0.11131195972835961d

   at osu.Game.Tests.Beatmaps.DifficultyCalculatorTest.Test(Double expectedStarRating, Int32 expectedMaxCombo, String name, Mod[] mods) in D:\a\osu\osu\osu.Game\Tests\Beatmaps\DifficultyCalculatorTest.cs:line 31
   at osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest.TestClockRateAdjusted(Double expectedStarRating, Int32 expectedMaxCombo, String name) in D:\a\osu\osu\osu.Game.Rulesets.Osu.Tests\OsuDifficultyCalculatorTest.cs:line 29

1)    at osu.Game.Tests.Beatmaps.DifficultyCalculatorTest.Test(Double expectedStarRating, Int32 expectedMaxCombo, String name, Mod[] mods) in D:\a\osu\osu\osu.Game\Tests\Beatmaps\DifficultyCalculatorTest.cs:line 31
   at osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest.TestClockRateAdjusted(Double expectedStarRating, Int32 expectedMaxCombo, String name) in D:\a\osu\osu\osu.Game.Rulesets.Osu.Tests\OsuDifficultyCalculatorTest.cs:line 29