Skip to content

small refactoring

small refactoring #347

GitHub Actions / Test Results (Windows, MultiThreaded) failed Sep 22, 2024 in 1s

10471 passed, 12 failed and 74 skipped

Tests failed

❌ TestResults-Windows-MultiThreaded.trx

10557 tests were completed in 2833s with 10471 passed, 12 failed and 74 skipped.

Test suite Passed Failed Skipped Time
osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest 10❌ 46ms
osu.Game.Tests.Visual.Editing.TestSceneEditorSaving 16✅ 2❌ 18s

❌ osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest

❌ Test(0.14102693012101306d,2,"nan-slider")
	  Expected: 0.14102693012101306d +/- 1.0000000000000001E-05d
	  But was:  0.0d
	  Off by:   0.14102693012101306d
	
❌ Test(0.4250648023083879d,4,"very-fast-slider")
	  Expected: 0.42506480230838789d +/- 1.0000000000000001E-05d
	  But was:  0.86131876564561183d
	  Off by:   -0.43625396333722394d
	
❌ Test(1.4386882251130073d,54,"zero-length-sliders")
	  Expected: 1.4386882251130073d +/- 1.0000000000000001E-05d
	  But was:  1.9763356469303219d
	  Off by:   -0.53764742181731462d
	
❌ Test(6.710442985146793d,239,"diffcalc-test")
	  Expected: 6.710442985146793d +/- 1.0000000000000001E-05d
	  But was:  6.5788549192303876d
	  Off by:   0.13158806591640548d
	
❌ TestClassicMod(0.4250648023083879d,4,"very-fast-slider")
	  Expected: 0.42506480230838789d +/- 1.0000000000000001E-05d
	  But was:  0.86131876564561183d
	  Off by:   -0.43625396333722394d
	
❌ TestClassicMod(1.4386882251130073d,54,"zero-length-sliders")
	  Expected: 1.4386882251130073d +/- 1.0000000000000001E-05d
	  But was:  1.9763356469303219d
	  Off by:   -0.53764742181731462d
	
❌ TestClassicMod(6.710442985146793d,239,"diffcalc-test")
	  Expected: 6.710442985146793d +/- 1.0000000000000001E-05d
	  But was:  6.5788549192303876d
	  Off by:   0.13158806591640548d
	
❌ TestClockRateAdjusted(0.5507108280047351d,4,"very-fast-slider")
	  Expected: 0.55071082800473514d +/- 1.0000000000000001E-05d
	  But was:  0.8698185801186018d
	  Off by:   -0.31910775211386666d
	
❌ TestClockRateAdjusted(1.743180218215227d,54,"zero-length-sliders")
	  Expected: 1.743180218215227d +/- 1.0000000000000001E-05d
	  But was:  1.9975906421689857d
	  Off by:   -0.25441042395375879d
	
❌ TestClockRateAdjusted(8.974295270307167d,239,"diffcalc-test")
	  Expected: 8.9742952703071666d +/- 1.0000000000000001E-05d
	  But was:  8.8109734133096129d
	  Off by:   0.16332185699755364d
	

❌ osu.Game.Tests.Visual.Editing.TestSceneEditorSaving

✅ TestBeatDivisor
✅ TestBeatDivisor
✅ TestCantExitWithoutSaving
✅ TestCantExitWithoutSaving
✅ TestConfiguration
✅ TestConfiguration
✅ TestConstructor
✅ TestConstructor
✅ TestDifficulty
✅ TestDifficulty
✅ TestExitWithoutSaveFromExistingBeatmap
✅ TestExitWithoutSaveFromExistingBeatmap
✅ TestHitObjectPlacement
✅ TestHitObjectPlacement
❌ TestLengthAndStarRatingUpdated
	  Expected: greater than 0.0d
	  But was:  0.0d
	
❌ TestLengthAndStarRatingUpdated
	  Expected: greater than 0.0d
	  But was:  0.0d
	
✅ TestMetadata
✅ TestMetadata

Annotations

Check failure on line 31 in osu.Game/Tests/Beatmaps/DifficultyCalculatorTest.cs

See this annotation in the file changed.

@github-actions github-actions / Test Results (Windows, MultiThreaded)

osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest ► Test(0.14102693012101306d,2,"nan-slider")

Failed test found in:
  TestResults-Windows-MultiThreaded.trx
Error:
    Expected: 0.14102693012101306d +/- 1.0000000000000001E-05d
    But was:  0.0d
    Off by:   0.14102693012101306d
  
Raw output
  Expected: 0.14102693012101306d +/- 1.0000000000000001E-05d
  But was:  0.0d
  Off by:   0.14102693012101306d

   at osu.Game.Tests.Beatmaps.DifficultyCalculatorTest.Test(Double expectedStarRating, Int32 expectedMaxCombo, String name, Mod[] mods) in D:\a\osu\osu\osu.Game\Tests\Beatmaps\DifficultyCalculatorTest.cs:line 31
   at osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest.Test(Double expectedStarRating, Int32 expectedMaxCombo, String name) in D:\a\osu\osu\osu.Game.Rulesets.Osu.Tests\OsuDifficultyCalculatorTest.cs:line 23
   at InvokeStub_OsuDifficultyCalculatorTest.Test(Object, Span`1)

1)    at osu.Game.Tests.Beatmaps.DifficultyCalculatorTest.Test(Double expectedStarRating, Int32 expectedMaxCombo, String name, Mod[] mods) in D:\a\osu\osu\osu.Game\Tests\Beatmaps\DifficultyCalculatorTest.cs:line 31
   at osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest.Test(Double expectedStarRating, Int32 expectedMaxCombo, String name) in D:\a\osu\osu\osu.Game.Rulesets.Osu.Tests\OsuDifficultyCalculatorTest.cs:line 23
   at InvokeStub_OsuDifficultyCalculatorTest.Test(Object, Span`1)

Check failure on line 31 in osu.Game/Tests/Beatmaps/DifficultyCalculatorTest.cs

See this annotation in the file changed.

@github-actions github-actions / Test Results (Windows, MultiThreaded)

osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest ► Test(0.4250648023083879d,4,"very-fast-slider")

Failed test found in:
  TestResults-Windows-MultiThreaded.trx
Error:
    Expected: 0.42506480230838789d +/- 1.0000000000000001E-05d
    But was:  0.86131876564561183d
    Off by:   -0.43625396333722394d
  
Raw output
  Expected: 0.42506480230838789d +/- 1.0000000000000001E-05d
  But was:  0.86131876564561183d
  Off by:   -0.43625396333722394d

   at osu.Game.Tests.Beatmaps.DifficultyCalculatorTest.Test(Double expectedStarRating, Int32 expectedMaxCombo, String name, Mod[] mods) in D:\a\osu\osu\osu.Game\Tests\Beatmaps\DifficultyCalculatorTest.cs:line 31
   at osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest.Test(Double expectedStarRating, Int32 expectedMaxCombo, String name) in D:\a\osu\osu\osu.Game.Rulesets.Osu.Tests\OsuDifficultyCalculatorTest.cs:line 23
   at InvokeStub_OsuDifficultyCalculatorTest.Test(Object, Span`1)

1)    at osu.Game.Tests.Beatmaps.DifficultyCalculatorTest.Test(Double expectedStarRating, Int32 expectedMaxCombo, String name, Mod[] mods) in D:\a\osu\osu\osu.Game\Tests\Beatmaps\DifficultyCalculatorTest.cs:line 31
   at osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest.Test(Double expectedStarRating, Int32 expectedMaxCombo, String name) in D:\a\osu\osu\osu.Game.Rulesets.Osu.Tests\OsuDifficultyCalculatorTest.cs:line 23
   at InvokeStub_OsuDifficultyCalculatorTest.Test(Object, Span`1)

Check failure on line 31 in osu.Game/Tests/Beatmaps/DifficultyCalculatorTest.cs

See this annotation in the file changed.

@github-actions github-actions / Test Results (Windows, MultiThreaded)

osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest ► Test(1.4386882251130073d,54,"zero-length-sliders")

Failed test found in:
  TestResults-Windows-MultiThreaded.trx
Error:
    Expected: 1.4386882251130073d +/- 1.0000000000000001E-05d
    But was:  1.9763356469303219d
    Off by:   -0.53764742181731462d
  
Raw output
  Expected: 1.4386882251130073d +/- 1.0000000000000001E-05d
  But was:  1.9763356469303219d
  Off by:   -0.53764742181731462d

   at osu.Game.Tests.Beatmaps.DifficultyCalculatorTest.Test(Double expectedStarRating, Int32 expectedMaxCombo, String name, Mod[] mods) in D:\a\osu\osu\osu.Game\Tests\Beatmaps\DifficultyCalculatorTest.cs:line 31
   at osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest.Test(Double expectedStarRating, Int32 expectedMaxCombo, String name) in D:\a\osu\osu\osu.Game.Rulesets.Osu.Tests\OsuDifficultyCalculatorTest.cs:line 23
   at InvokeStub_OsuDifficultyCalculatorTest.Test(Object, Span`1)

1)    at osu.Game.Tests.Beatmaps.DifficultyCalculatorTest.Test(Double expectedStarRating, Int32 expectedMaxCombo, String name, Mod[] mods) in D:\a\osu\osu\osu.Game\Tests\Beatmaps\DifficultyCalculatorTest.cs:line 31
   at osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest.Test(Double expectedStarRating, Int32 expectedMaxCombo, String name) in D:\a\osu\osu\osu.Game.Rulesets.Osu.Tests\OsuDifficultyCalculatorTest.cs:line 23
   at InvokeStub_OsuDifficultyCalculatorTest.Test(Object, Span`1)

Check failure on line 31 in osu.Game/Tests/Beatmaps/DifficultyCalculatorTest.cs

See this annotation in the file changed.

@github-actions github-actions / Test Results (Windows, MultiThreaded)

osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest ► Test(6.710442985146793d,239,"diffcalc-test")

Failed test found in:
  TestResults-Windows-MultiThreaded.trx
Error:
    Expected: 6.710442985146793d +/- 1.0000000000000001E-05d
    But was:  6.5788549192303876d
    Off by:   0.13158806591640548d
  
Raw output
  Expected: 6.710442985146793d +/- 1.0000000000000001E-05d
  But was:  6.5788549192303876d
  Off by:   0.13158806591640548d

   at osu.Game.Tests.Beatmaps.DifficultyCalculatorTest.Test(Double expectedStarRating, Int32 expectedMaxCombo, String name, Mod[] mods) in D:\a\osu\osu\osu.Game\Tests\Beatmaps\DifficultyCalculatorTest.cs:line 31
   at osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest.Test(Double expectedStarRating, Int32 expectedMaxCombo, String name) in D:\a\osu\osu\osu.Game.Rulesets.Osu.Tests\OsuDifficultyCalculatorTest.cs:line 23

1)    at osu.Game.Tests.Beatmaps.DifficultyCalculatorTest.Test(Double expectedStarRating, Int32 expectedMaxCombo, String name, Mod[] mods) in D:\a\osu\osu\osu.Game\Tests\Beatmaps\DifficultyCalculatorTest.cs:line 31
   at osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest.Test(Double expectedStarRating, Int32 expectedMaxCombo, String name) in D:\a\osu\osu\osu.Game.Rulesets.Osu.Tests\OsuDifficultyCalculatorTest.cs:line 23

Check failure on line 31 in osu.Game/Tests/Beatmaps/DifficultyCalculatorTest.cs

See this annotation in the file changed.

@github-actions github-actions / Test Results (Windows, MultiThreaded)

osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest ► TestClassicMod(0.4250648023083879d,4,"very-fast-slider")

Failed test found in:
  TestResults-Windows-MultiThreaded.trx
Error:
    Expected: 0.42506480230838789d +/- 1.0000000000000001E-05d
    But was:  0.86131876564561183d
    Off by:   -0.43625396333722394d
  
Raw output
  Expected: 0.42506480230838789d +/- 1.0000000000000001E-05d
  But was:  0.86131876564561183d
  Off by:   -0.43625396333722394d

   at osu.Game.Tests.Beatmaps.DifficultyCalculatorTest.Test(Double expectedStarRating, Int32 expectedMaxCombo, String name, Mod[] mods) in D:\a\osu\osu\osu.Game\Tests\Beatmaps\DifficultyCalculatorTest.cs:line 31
   at osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest.TestClassicMod(Double expectedStarRating, Int32 expectedMaxCombo, String name) in D:\a\osu\osu\osu.Game.Rulesets.Osu.Tests\OsuDifficultyCalculatorTest.cs:line 35
   at InvokeStub_OsuDifficultyCalculatorTest.TestClassicMod(Object, Span`1)

1)    at osu.Game.Tests.Beatmaps.DifficultyCalculatorTest.Test(Double expectedStarRating, Int32 expectedMaxCombo, String name, Mod[] mods) in D:\a\osu\osu\osu.Game\Tests\Beatmaps\DifficultyCalculatorTest.cs:line 31
   at osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest.TestClassicMod(Double expectedStarRating, Int32 expectedMaxCombo, String name) in D:\a\osu\osu\osu.Game.Rulesets.Osu.Tests\OsuDifficultyCalculatorTest.cs:line 35
   at InvokeStub_OsuDifficultyCalculatorTest.TestClassicMod(Object, Span`1)

Check failure on line 31 in osu.Game/Tests/Beatmaps/DifficultyCalculatorTest.cs

See this annotation in the file changed.

@github-actions github-actions / Test Results (Windows, MultiThreaded)

osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest ► TestClassicMod(1.4386882251130073d,54,"zero-length-sliders")

Failed test found in:
  TestResults-Windows-MultiThreaded.trx
Error:
    Expected: 1.4386882251130073d +/- 1.0000000000000001E-05d
    But was:  1.9763356469303219d
    Off by:   -0.53764742181731462d
  
Raw output
  Expected: 1.4386882251130073d +/- 1.0000000000000001E-05d
  But was:  1.9763356469303219d
  Off by:   -0.53764742181731462d

   at osu.Game.Tests.Beatmaps.DifficultyCalculatorTest.Test(Double expectedStarRating, Int32 expectedMaxCombo, String name, Mod[] mods) in D:\a\osu\osu\osu.Game\Tests\Beatmaps\DifficultyCalculatorTest.cs:line 31
   at osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest.TestClassicMod(Double expectedStarRating, Int32 expectedMaxCombo, String name) in D:\a\osu\osu\osu.Game.Rulesets.Osu.Tests\OsuDifficultyCalculatorTest.cs:line 35
   at InvokeStub_OsuDifficultyCalculatorTest.TestClassicMod(Object, Span`1)

1)    at osu.Game.Tests.Beatmaps.DifficultyCalculatorTest.Test(Double expectedStarRating, Int32 expectedMaxCombo, String name, Mod[] mods) in D:\a\osu\osu\osu.Game\Tests\Beatmaps\DifficultyCalculatorTest.cs:line 31
   at osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest.TestClassicMod(Double expectedStarRating, Int32 expectedMaxCombo, String name) in D:\a\osu\osu\osu.Game.Rulesets.Osu.Tests\OsuDifficultyCalculatorTest.cs:line 35
   at InvokeStub_OsuDifficultyCalculatorTest.TestClassicMod(Object, Span`1)

Check failure on line 31 in osu.Game/Tests/Beatmaps/DifficultyCalculatorTest.cs

See this annotation in the file changed.

@github-actions github-actions / Test Results (Windows, MultiThreaded)

osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest ► TestClassicMod(6.710442985146793d,239,"diffcalc-test")

Failed test found in:
  TestResults-Windows-MultiThreaded.trx
Error:
    Expected: 6.710442985146793d +/- 1.0000000000000001E-05d
    But was:  6.5788549192303876d
    Off by:   0.13158806591640548d
  
Raw output
  Expected: 6.710442985146793d +/- 1.0000000000000001E-05d
  But was:  6.5788549192303876d
  Off by:   0.13158806591640548d

   at osu.Game.Tests.Beatmaps.DifficultyCalculatorTest.Test(Double expectedStarRating, Int32 expectedMaxCombo, String name, Mod[] mods) in D:\a\osu\osu\osu.Game\Tests\Beatmaps\DifficultyCalculatorTest.cs:line 31
   at osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest.TestClassicMod(Double expectedStarRating, Int32 expectedMaxCombo, String name) in D:\a\osu\osu\osu.Game.Rulesets.Osu.Tests\OsuDifficultyCalculatorTest.cs:line 35

1)    at osu.Game.Tests.Beatmaps.DifficultyCalculatorTest.Test(Double expectedStarRating, Int32 expectedMaxCombo, String name, Mod[] mods) in D:\a\osu\osu\osu.Game\Tests\Beatmaps\DifficultyCalculatorTest.cs:line 31
   at osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest.TestClassicMod(Double expectedStarRating, Int32 expectedMaxCombo, String name) in D:\a\osu\osu\osu.Game.Rulesets.Osu.Tests\OsuDifficultyCalculatorTest.cs:line 35

Check failure on line 31 in osu.Game/Tests/Beatmaps/DifficultyCalculatorTest.cs

See this annotation in the file changed.

@github-actions github-actions / Test Results (Windows, MultiThreaded)

osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest ► TestClockRateAdjusted(0.5507108280047351d,4,"very-fast-slider")

Failed test found in:
  TestResults-Windows-MultiThreaded.trx
Error:
    Expected: 0.55071082800473514d +/- 1.0000000000000001E-05d
    But was:  0.8698185801186018d
    Off by:   -0.31910775211386666d
  
Raw output
  Expected: 0.55071082800473514d +/- 1.0000000000000001E-05d
  But was:  0.8698185801186018d
  Off by:   -0.31910775211386666d

   at osu.Game.Tests.Beatmaps.DifficultyCalculatorTest.Test(Double expectedStarRating, Int32 expectedMaxCombo, String name, Mod[] mods) in D:\a\osu\osu\osu.Game\Tests\Beatmaps\DifficultyCalculatorTest.cs:line 31
   at osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest.TestClockRateAdjusted(Double expectedStarRating, Int32 expectedMaxCombo, String name) in D:\a\osu\osu\osu.Game.Rulesets.Osu.Tests\OsuDifficultyCalculatorTest.cs:line 29
   at InvokeStub_OsuDifficultyCalculatorTest.TestClockRateAdjusted(Object, Span`1)

1)    at osu.Game.Tests.Beatmaps.DifficultyCalculatorTest.Test(Double expectedStarRating, Int32 expectedMaxCombo, String name, Mod[] mods) in D:\a\osu\osu\osu.Game\Tests\Beatmaps\DifficultyCalculatorTest.cs:line 31
   at osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest.TestClockRateAdjusted(Double expectedStarRating, Int32 expectedMaxCombo, String name) in D:\a\osu\osu\osu.Game.Rulesets.Osu.Tests\OsuDifficultyCalculatorTest.cs:line 29
   at InvokeStub_OsuDifficultyCalculatorTest.TestClockRateAdjusted(Object, Span`1)

Check failure on line 31 in osu.Game/Tests/Beatmaps/DifficultyCalculatorTest.cs

See this annotation in the file changed.

@github-actions github-actions / Test Results (Windows, MultiThreaded)

osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest ► TestClockRateAdjusted(1.743180218215227d,54,"zero-length-sliders")

Failed test found in:
  TestResults-Windows-MultiThreaded.trx
Error:
    Expected: 1.743180218215227d +/- 1.0000000000000001E-05d
    But was:  1.9975906421689857d
    Off by:   -0.25441042395375879d
  
Raw output
  Expected: 1.743180218215227d +/- 1.0000000000000001E-05d
  But was:  1.9975906421689857d
  Off by:   -0.25441042395375879d

   at osu.Game.Tests.Beatmaps.DifficultyCalculatorTest.Test(Double expectedStarRating, Int32 expectedMaxCombo, String name, Mod[] mods) in D:\a\osu\osu\osu.Game\Tests\Beatmaps\DifficultyCalculatorTest.cs:line 31
   at osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest.TestClockRateAdjusted(Double expectedStarRating, Int32 expectedMaxCombo, String name) in D:\a\osu\osu\osu.Game.Rulesets.Osu.Tests\OsuDifficultyCalculatorTest.cs:line 29
   at InvokeStub_OsuDifficultyCalculatorTest.TestClockRateAdjusted(Object, Span`1)

1)    at osu.Game.Tests.Beatmaps.DifficultyCalculatorTest.Test(Double expectedStarRating, Int32 expectedMaxCombo, String name, Mod[] mods) in D:\a\osu\osu\osu.Game\Tests\Beatmaps\DifficultyCalculatorTest.cs:line 31
   at osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest.TestClockRateAdjusted(Double expectedStarRating, Int32 expectedMaxCombo, String name) in D:\a\osu\osu\osu.Game.Rulesets.Osu.Tests\OsuDifficultyCalculatorTest.cs:line 29
   at InvokeStub_OsuDifficultyCalculatorTest.TestClockRateAdjusted(Object, Span`1)

Check failure on line 31 in osu.Game/Tests/Beatmaps/DifficultyCalculatorTest.cs

See this annotation in the file changed.

@github-actions github-actions / Test Results (Windows, MultiThreaded)

osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest ► TestClockRateAdjusted(8.974295270307167d,239,"diffcalc-test")

Failed test found in:
  TestResults-Windows-MultiThreaded.trx
Error:
    Expected: 8.9742952703071666d +/- 1.0000000000000001E-05d
    But was:  8.8109734133096129d
    Off by:   0.16332185699755364d
  
Raw output
  Expected: 8.9742952703071666d +/- 1.0000000000000001E-05d
  But was:  8.8109734133096129d
  Off by:   0.16332185699755364d

   at osu.Game.Tests.Beatmaps.DifficultyCalculatorTest.Test(Double expectedStarRating, Int32 expectedMaxCombo, String name, Mod[] mods) in D:\a\osu\osu\osu.Game\Tests\Beatmaps\DifficultyCalculatorTest.cs:line 31
   at osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest.TestClockRateAdjusted(Double expectedStarRating, Int32 expectedMaxCombo, String name) in D:\a\osu\osu\osu.Game.Rulesets.Osu.Tests\OsuDifficultyCalculatorTest.cs:line 29

1)    at osu.Game.Tests.Beatmaps.DifficultyCalculatorTest.Test(Double expectedStarRating, Int32 expectedMaxCombo, String name, Mod[] mods) in D:\a\osu\osu\osu.Game\Tests\Beatmaps\DifficultyCalculatorTest.cs:line 31
   at osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest.TestClockRateAdjusted(Double expectedStarRating, Int32 expectedMaxCombo, String name) in D:\a\osu\osu\osu.Game.Rulesets.Osu.Tests\OsuDifficultyCalculatorTest.cs:line 29

Check failure on line 172 in osu.Game.Tests/Visual/Editing/TestSceneEditorSaving.cs

See this annotation in the file changed.

@github-actions github-actions / Test Results (Windows, MultiThreaded)

osu.Game.Tests.Visual.Editing.TestSceneEditorSaving ► TestLengthAndStarRatingUpdated

Failed test found in:
  TestResults-Windows-MultiThreaded.trx
Error:
    Expected: greater than 0.0d
    But was:  0.0d
  
Raw output
  Expected: greater than 0.0d
  But was:  0.0d

   at osu.Game.Tests.Visual.Editing.TestSceneEditorSaving.<>c__DisplayClass5_0.<TestLengthAndStarRatingUpdated>b__14() in D:\a\osu\osu\osu.Game.Tests\Visual\Editing\TestSceneEditorSaving.cs:line 172
   at osu.Framework.Testing.Drawables.Steps.SingleStepButton.<.ctor>b__1_0()
   at osu.Framework.Testing.Drawables.Steps.StepButton.PerformStep(Boolean userTriggered)
   at osu.Framework.Testing.TestScene.runNextStep(Action onCompletion, Action`1 onError, Func`2 stopCondition)
--- End of stack trace from previous location ---
   at osu.Framework.Testing.TestSceneTestRunner.TestRunner.RunTestBlocking(TestScene test)
   at osu.Game.Tests.Visual.OsuTestScene.OsuTestSceneTestRunner.RunTestBlocking(TestScene test) in D:\a\osu\osu\osu.Game\Tests\Visual\OsuTestScene.cs:line 541
   at osu.Framework.Testing.TestScene.UseTestSceneRunnerAttribute.AfterTest(ITest test)
   at NUnit.Framework.Internal.Commands.TestActionCommand.<>c__DisplayClass0_0.<.ctor>b__1(TestExecutionContext context)
   at NUnit.Framework.Internal.Commands.BeforeAndAfterTestCommand.<>c__DisplayClass1_0.<Execute>b__1()
   at NUnit.Framework.Internal.Commands.DelegatingTestCommand.RunTestMethodInThreadAbortSafeZone(TestExecutionContext context, Action action)

1)    at osu.Game.Tests.Visual.Editing.TestSceneEditorSaving.<>c__DisplayClass5_0.<TestLengthAndStarRatingUpdated>b__14() in D:\a\osu\osu\osu.Game.Tests\Visual\Editing\TestSceneEditorSaving.cs:line 172
   at osu.Framework.Testing.Drawables.Steps.SingleStepButton.<.ctor>b__1_0()
   at osu.Framework.Testing.Drawables.Steps.StepButton.PerformStep(Boolean userTriggered)
   at osu.Framework.Testing.TestScene.runNextStep(Action onCompletion, Action`1 onError, Func`2 stopCondition)
   at osu.Framework.Threading.ScheduledDelegate.RunTaskInternal()
   at osu.Framework.Threading.Scheduler.Update()
   at osu.Framework.Graphics.Drawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Platform.GameHost.UpdateFrame()
   at osu.Framework.Threading.GameThread.processFrame()
   at osu.Framework.Threading.GameThread.<createThread>g__runWork|70_0()