WIP : Adding ikea e1524/e1810

[paddyponchero]

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

• If your changes affects code, did your write the tests?
• Are tests passing? (npm test on both front/server)
• Is the linter passing? (npm run eslint on both front/server)
• Did you run prettier? (npm run prettier on both front/server)
• If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
• Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community (french forum/english forum) for testing before merging.
• If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
• If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.
• Did you add fake requests data for the demo mode (front/src/config/demo.js) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Please provide a description of the change here. It's always best with screenshots, so don't hesitate to add some!

[relativeci]

#2864 Bundle Size — 10.26MiB (+0.02%).

ffab50b(current) vs 2540927 master#2858(baseline)

Warning

Bundle contains 3 duplicate packages – View duplicate packages

Bundle metrics   2 changes 1 regression

	Current #2864	Baseline #2858
Initial JS	5.56MiB(+0.03%)	5.56MiB
Initial CSS	304.68KiB	304.68KiB
Cache Invalidation	54.08%	54.06%
Chunks	51	51
Assets	171	171
Modules	1495	1495
Duplicate Modules	21	21
Duplicate Code	0.84%	0.84%
Packages	124	124
Duplicate Packages	3	3

Bundle size by type   1 change 1 regression

	Current #2864	Baseline #2858
JS	7.35MiB (+0.02%)	7.35MiB
IMG	2.48MiB	2.48MiB
CSS	321.47KiB	321.47KiB
Fonts	93.55KiB	93.55KiB
Other	17.62KiB	17.62KiB
HTML	13.58KiB	13.58KiB

Bundle analysis report Branch paddyponchero:adding-IKEA-E1524/... Project dashboard

---

^{Generated by RelativeCI Documentation Report issue}

[Pierre-Gilles]

hey @paddyponchero, any news on this PR ? :)

[paddyponchero]

I don't have much time as I am renovating a house in evenings and weekends on top of a full time job. I was having trouble pushing the changes to github after test, prettier etc.

…

On Mon, 30 Sept 2024, 04:12 Pierre-Gilles Leymarie, < ***@***.***> wrote: hey @paddyponchero <https://github.com/paddyponchero>, any news on this PR ? :) — Reply to this email directly, view it on GitHub <#2120 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACELGZA2PT2JPKRXIIHATF3ZZC6SBAVCNFSM6AAAAABOLE6ZNKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOBRHEYTONRVGE> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[Pierre-Gilles]

Ok, let me know if you need help finishing this! Good luck on your house :)

[Pierre-Gilles]

Hey @paddyponchero, the PR is just missing a npm run prettier in the server folder, I would love to merge this in Gladys :)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.52%. Comparing base (2540927) to head (ffab50b).

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #2120   +/-   ##
=======================================
  Coverage   98.52%   98.52%           
=======================================
  Files         867      867           
  Lines       14272    14280    +8     
=======================================
+ Hits        14061    14069    +8     
  Misses        211      211           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[paddyponchero]

Hey @paddyponchero, the PR is just missing a npm run prettier in the server folder, I would love to merge this in Gladys :)

Seems to have pushed correctly this time. Thanks.

[paddyponchero]

Seems to have pushed properly now,

…

On Fri, 8 Nov 2024, 16:20 Pierre-Gilles Leymarie, ***@***.***> wrote: Hey @paddyponchero <https://github.com/paddyponchero>, the PR is just missing a npm run prettier in the server folder, I would love to merge this in Gladys :) — Reply to this email directly, view it on GitHub <#2120 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACELGZGVVCILIJR7DN6INDDZ7TQEDAVCNFSM6AAAAABOLE6ZNKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINRVGE4TINZUGQ> . You are receiving this because you were mentioned.Message ID: ***@***.***>