Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Netatmo doc - add NRV #253

Merged
merged 3 commits into from
Feb 19, 2024

Conversation

Terdious
Copy link
Contributor

@Terdious Terdious commented Feb 10, 2024

Add doc new Netatmo integration - valve NRV

link with PR n°1 : Add support for NRV module type - Energy / Valves #2014

@Terdious Terdious changed the title Add doc new Netatmo integration - valve NRV Update Netatmo doc Feb 11, 2024
Pierre-Gilles
Pierre-Gilles previously approved these changes Feb 12, 2024
Copy link
Contributor

@Pierre-Gilles Pierre-Gilles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR 👏

@Terdious Terdious changed the title Update Netatmo doc Update Netatmo doc - add NRV Feb 12, 2024
@Terdious
Copy link
Contributor Author

Not knowing in what order you would put the PRs, I thought it would be good to modify the 2 images that were too heavy in the 2 PRs... bad idea.. sorry.
Can you resolve the conflict yourself easily or is it better for me to do it?

@Pierre-Gilles
Copy link
Contributor

You should resolve it yourself !

@Terdious
Copy link
Contributor Author

It's good for me @Pierre-Gilles

@Pierre-Gilles Pierre-Gilles merged commit b684467 into GladysAssistant:master Feb 19, 2024
2 checks passed
@Terdious Terdious deleted the doc-netatmo-nrv branch February 22, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants