feat: pull request #2253 from GlobalFishingWatch/fishing-map/test-new…

…-sar-dataset-filters Test new SAR dataset filters
GlobalFishingWatch · Oct 17, 2023 · 811a9d6 · 811a9d6
2 parents 25c8e38 + 06ed9f4
commit 811a9d6
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 2 deletions.
diff --git a/apps/fishing-map/features/datasets/datasets.utils.ts b/apps/fishing-map/features/datasets/datasets.utils.ts
@@ -423,6 +423,9 @@ export const getIncompatibleFilterSelection = (
     }
     return incompatibilityDict.filter(({ id, value, disabled }) => {
       const selectedFilterValue = dataview.config?.filters?.[id]
+      if (value === 'undefined' && selectedFilterValue === undefined) {
+        return disabled.includes(schema)
+      }
       return (
         disabled.includes(schema) &&
         selectedFilterValue?.length === 1 &&

diff --git a/apps/fishing-map/features/dataviews/dataviews.mock.ts b/apps/fishing-map/features/dataviews/dataviews.mock.ts
@@ -1,4 +1,4 @@
-import { Dataview } from '@globalfishingwatch/api-types'
+import { Dataview, DataviewCategory } from '@globalfishingwatch/api-types'
 
 export const dataviews: Dataview[] = []
 

diff --git a/libs/api-types/src/dataviews.ts b/libs/api-types/src/dataviews.ts
@@ -70,7 +70,7 @@ export interface DataviewEventsConfig {
 
 export interface IncomatibleFilterConfig {
   id: string // id of the filter
-  value: boolean // value to match
+  value: boolean | string // value to match
   disabled: string[] // disabled filter on matches
 }